Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2579603002: Revert of Give automation extension api owners ownership of externs (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
redevlin.cronin, David Tseng
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org, aboxhall, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Give automation extension api owners ownership of externs (patchset #2 id:20001 of https://codereview.chromium.org/2576053002/ ) Reason for revert: Manually editing generated files is not the right way to change things in this folder. https://codereview.chromium.org/2563013003/ https://codereview.chromium.org/2544203004/ Please either fix the tools, report bugs, or remove generation steps (or move these externs to somewhere else), then resubmit this CL. Original issue's description: > Give automation extension api owners ownership of externs > > BUG= > > Committed: https://crrev.com/484e132178179990a45f6c74c218d12bee61f094 > Cr-Commit-Position: refs/heads/master@{#438680} TBR=redevlin.cronin@chromium.org,dtseng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9807edde1147b92a6613f6bf26d84b1d0fcc939f Cr-Commit-Position: refs/heads/master@{#438688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/closure_compiler/externs/OWNERS View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dan Beam
Created Revert of Give automation extension api owners ownership of externs
4 years ago (2016-12-15 00:36:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579603002/1
4 years ago (2016-12-15 00:38:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 00:39:18 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-15 00:41:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9807edde1147b92a6613f6bf26d84b1d0fcc939f
Cr-Commit-Position: refs/heads/master@{#438688}

Powered by Google App Engine
This is Rietveld 408576698