Reland Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl

Reland Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl

This was reverted due to crbug.com/673736. Fixed.

Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl to AwContentsClientBridge. This is a continuation of the work started in
https://codereview.chromium.org/2425423004/ and is the third patch.

BUG=645983
Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a
Cr-Commit-Position: refs/heads/master@{#437688}

patch from issue 2558223002 at patchset 120001 (http://crrev.com/2558223002#ps120001)

Committed: https://crrev.com/a982815efb09df02eac3c2f716360d2420c3c94b
Cr-Commit-Position: refs/heads/master@{#438891}

[sgurun-gerrit only, 2016-12-15 18:10:08]

sgurun@chromium.org changed reviewers:
+ jam@chromium.org

[sgurun-gerrit only, 2016-12-15 18:10:09]

PTAL

the original CL was also mentioned as a cause of crbug/673330
but I don't really see how. I am guessing it is an issue with the bisect.

https://codereview.chromium.org/2579533003/diff/20001/android_webview/browser...
File
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/2579533003/diff/20001/android_webview/browser...
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc:344:
content::ResourceRequestInfo::ForRequest(request);
jam@: does this require a null check too? I see we do a null check below in
OnResponseStarted but not super sure.

[jam, 2016-12-15 18:34:31]

lgtm, thanks

https://codereview.chromium.org/2579533003/diff/20001/android_webview/browser...
File
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/2579533003/diff/20001/android_webview/browser...
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc:344:
content::ResourceRequestInfo::ForRequest(request);
On 2016/12/15 18:10:08, sgurun wrote:
> jam@: does this require a null check too? I see we do a null check below in
> OnResponseStarted but not super sure.

Since downloads are probably only triggered by code that content knows about,
then it's not needed.

[sgurun-gerrit only, 2016-12-15 18:35:46]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2016-12-15 18:36:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 19:25:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481826946581240,
"parent_rev": "ffe4f09ff9729d3a63a6f60548f93206c732af26", "commit_rev":
"ade6e7edc7a037d29aa7ed11bf89540be772f45a"}

[commit-bot: I haz the power, 2016-12-15 19:25:50]

Description was changed from

==========
Reland Move onReceivedError and onReceivedHttpError out of
AwContentsIoThreadClientImpl

This was reverted due to crbug.com/673736. Fixed.

Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl
to AwContentsClientBridge. This is a continuation of the work started in
https://codereview.chromium.org/2425423004/ and is the third patch.

BUG=645983

Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a
Cr-Commit-Position: refs/heads/master@{#437688}

patch from issue 2558223002 at patchset 120001
(http://crrev.com/2558223002#ps120001)
==========

to

==========
Reland Move onReceivedError and onReceivedHttpError out of
AwContentsIoThreadClientImpl

This was reverted due to crbug.com/673736. Fixed.

Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl
to AwContentsClientBridge. This is a continuation of the work started in
https://codereview.chromium.org/2425423004/ and is the third patch.

BUG=645983

Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a
Cr-Commit-Position: refs/heads/master@{#437688}

patch from issue 2558223002 at patchset 120001
(http://crrev.com/2558223002#ps120001)

Review-Url: https://codereview.chromium.org/2579533003
==========

[commit-bot: I haz the power, 2016-12-15 19:25:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 19:27:31]

Description was changed from

==========
Reland Move onReceivedError and onReceivedHttpError out of
AwContentsIoThreadClientImpl

This was reverted due to crbug.com/673736. Fixed.

Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl
to AwContentsClientBridge. This is a continuation of the work started in
https://codereview.chromium.org/2425423004/ and is the third patch.

BUG=645983

Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a
Cr-Commit-Position: refs/heads/master@{#437688}

patch from issue 2558223002 at patchset 120001
(http://crrev.com/2558223002#ps120001)

Review-Url: https://codereview.chromium.org/2579533003
==========

to

==========
Reland Move onReceivedError and onReceivedHttpError out of
AwContentsIoThreadClientImpl

This was reverted due to crbug.com/673736. Fixed.

Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl
to AwContentsClientBridge. This is a continuation of the work started in
https://codereview.chromium.org/2425423004/ and is the third patch.

BUG=645983

Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a
Cr-Commit-Position: refs/heads/master@{#437688}

patch from issue 2558223002 at patchset 120001
(http://crrev.com/2558223002#ps120001)

Committed: https://crrev.com/a982815efb09df02eac3c2f716360d2420c3c94b
Cr-Commit-Position: refs/heads/master@{#438891}
==========

[commit-bot: I haz the power, 2016-12-15 19:27:31]

Patchset 2 (id:??) landed as
https://crrev.com/a982815efb09df02eac3c2f716360d2420c3c94b
Cr-Commit-Position: refs/heads/master@{#438891}