Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2579433002: MD Settings: Internet: Hide subpage arrow when disabled (Closed)

Created:
4 years ago by stevenjb
Modified:
4 years ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Hide subpage arrow when disabled BUG=668341 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f9ed2ee38f7e2f0c9109be6d00552577aaaf2e7f Cr-Commit-Position: refs/heads/master@{#438937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
stevenjb
This fixes a minor oversight from my previous CL; we do not want to show ...
4 years ago (2016-12-14 20:13:20 UTC) #3
dschuyler
lgtm
4 years ago (2016-12-15 02:26:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579433002/1
4 years ago (2016-12-15 02:32:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/335084) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-15 02:39:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579433002/1
4 years ago (2016-12-15 21:44:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 22:30:48 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 22:34:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9ed2ee38f7e2f0c9109be6d00552577aaaf2e7f
Cr-Commit-Position: refs/heads/master@{#438937}

Powered by Google App Engine
This is Rietveld 408576698