Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2579373002:
[Payments] Add integration tests for auto advance in card editor (Closed)
DescriptionAdd integration tests for auto advance in card editor
BUG=666885
Committed: https://crrev.com/b107359eaae09cbf7bd1b86b6751f98c39c49bb5
Cr-Commit-Position: refs/heads/master@{#439341}
Patch Set 1 #
Total comments: 10
Patch Set 2 : address comments #
Messages
Total messages: 25 (13 generated)
Description was changed from ========== Add integration tests for auto advance in card editor Add integration tests for auto-advance in card editor Add integration tests for auto-advance in card editor add integrations tests for auto-advance in cardEditor BUG= ========== to ========== Add integration tests for auto advance in card editor BUG=666885 ==========
Patchset #1 (id:1) has been deleted
gogerald@chromium.org changed reviewers: + rouslan@chromium.org
Hi rouslan@, PTAL. Adding integration tests for auto advance in card editor.
mathp@chromium.org changed reviewers: + mathp@chromium.org
https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java (right): https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:33: // to payment section. *the payment section https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:51: // Dinners credit card. *Diners https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:60: setTextInCardEditorAndWait(new String[] {"3056 9309 0259 04"}, mEditorTextUpdate); Add a comment saying that this is now a valid number https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:69: setTextInCardEditorAndWait(new String[] {"3056 9309 0259 041"}, mEditorTextUpdate); Add a comment saying we expect focus to stay in the field in the error state
On 2016/12/16 21:24:58, Mathieu Perreault wrote: > https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... > File > chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java > (right): > > https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... > chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:33: > // to payment section. > *the payment section > > https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... > chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:51: > // Dinners credit card. > *Diners > > https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... > chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:60: > setTextInCardEditorAndWait(new String[] {"3056 9309 0259 04"}, > mEditorTextUpdate); > Add a comment saying that this is now a valid number > > https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... > chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:69: > setTextInCardEditorAndWait(new String[] {"3056 9309 0259 041"}, > mEditorTextUpdate); > Add a comment saying we expect focus to stay in the field in the error state Thanks for doing this by the way!
Thank you for the tests! :-D LGTM % my comment and the comments by Mathieu. https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java (right): https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:53: setTextInCardEditorAndWait(new String[] {"3056 9309 0259 0"}, mEditorTextUpdate); These numbers look too real. Please add a link to the page where I got this numbers. I assume it's something lik e https://stripe.com/docs/testing#cards
https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java (right): https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:33: // to payment section. On 2016/12/16 21:24:58, Mathieu Perreault wrote: > *the payment section Done. https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:51: // Dinners credit card. On 2016/12/16 21:24:58, Mathieu Perreault wrote: > *Diners Done. https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:53: setTextInCardEditorAndWait(new String[] {"3056 9309 0259 0"}, mEditorTextUpdate); On 2016/12/16 21:51:29, rouslan wrote: > These numbers look too real. Please add a link to the page where I got this > numbers. I assume it's something lik e https://stripe.com/docs/testing#cards Done. https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:60: setTextInCardEditorAndWait(new String[] {"3056 9309 0259 04"}, mEditorTextUpdate); On 2016/12/16 21:24:58, Mathieu Perreault wrote: > Add a comment saying that this is now a valid number Done. https://codereview.chromium.org/2579373002/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java:69: setTextInCardEditorAndWait(new String[] {"3056 9309 0259 041"}, mEditorTextUpdate); On 2016/12/16 21:24:58, Mathieu Perreault wrote: > Add a comment saying we expect focus to stay in the field in the error state Done.
The CQ bit was checked by gogerald@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2579373002/#ps40001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481980716908410,
"parent_rev": "f2b768b8d9846ae80fb340be367fc90034943507", "commit_rev":
"fdd6b2601f47e66c7d19ae6fba2329ef597ffca5"}
Message was sent while issue was closed.
Description was changed from ========== Add integration tests for auto advance in card editor BUG=666885 ========== to ========== Add integration tests for auto advance in card editor BUG=666885 Review-Url: https://codereview.chromium.org/2579373002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add integration tests for auto advance in card editor BUG=666885 Review-Url: https://codereview.chromium.org/2579373002 ========== to ========== Add integration tests for auto advance in card editor BUG=666885 Committed: https://crrev.com/b107359eaae09cbf7bd1b86b6751f98c39c49bb5 Cr-Commit-Position: refs/heads/master@{#439341} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b107359eaae09cbf7bd1b86b6751f98c39c49bb5 Cr-Commit-Position: refs/heads/master@{#439341} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
