Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2579363002: Support saturation overrides in saturated_cast (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
eae
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support saturation overrides in saturated_cast This is a requirement for adding a full saturated type implementation. BUG=672489 TBR=eae NOTRY=true Committed: https://crrev.com/71b669adca7b10a7fcecec151ec8b1c66a4c90a0 Cr-Commit-Position: refs/heads/master@{#439274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -89 lines) Patch
M base/numerics/safe_conversions.h View 3 chunks +48 lines, -63 lines 0 comments Download
M base/numerics/safe_conversions_impl.h View 2 chunks +63 lines, -17 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 3 chunks +47 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579363002/1
4 years ago (2016-12-16 19:52:51 UTC) #2
jschuh
I had a merge error that broke the android builders. So, I'm relanding this as ...
4 years ago (2016-12-16 19:54:09 UTC) #3
eae
RS-LGTM
4 years ago (2016-12-16 19:55:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/182245) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
4 years ago (2016-12-16 21:51:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579363002/1
4 years ago (2016-12-16 21:58:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/281353) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-16 22:34:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579363002/1
4 years ago (2016-12-16 22:47:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/334980) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-17 00:34:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579363002/1
4 years ago (2016-12-17 01:03:35 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 01:14:04 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-17 01:16:05 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71b669adca7b10a7fcecec151ec8b1c66a4c90a0
Cr-Commit-Position: refs/heads/master@{#439274}

Powered by Google App Engine
This is Rietveld 408576698