Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2579323002: Clamps the character ranges for which bounds are requested so that they fall within the number of p… (Closed)

Created:
4 years ago by nektarios
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamps the character ranges for which bounds are requested so that they fall within the number of pixel offsets provided by Blink. Blink doesn't always return the location of all the characters in an inline text box. BUG=674273 R=dmazzoni@chromium.org TESTED=manually using NVDA's Python Console and by calling get_characterExtents(offset, 0) and (offset, 1) on a few paragraphs Committed: https://crrev.com/69c6cdedd7cde09c9f9672a702e80e3defec5314 Cr-Commit-Position: refs/heads/master@{#439165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nektarios
4 years ago (2016-12-16 17:17:55 UTC) #1
dmazzoni
lgtm
4 years ago (2016-12-16 17:20:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579323002/1
4 years ago (2016-12-16 18:13:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 19:23:33 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-16 19:26:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69c6cdedd7cde09c9f9672a702e80e3defec5314
Cr-Commit-Position: refs/heads/master@{#439165}

Powered by Google App Engine
This is Rietveld 408576698