Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2579273002: Revert of [turbofan] Remove value numbering from late optimization pass. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Remove value numbering from late optimization pass. (patchset #1 id:1 of https://codereview.chromium.org/2570813002/ ) Reason for revert: Tanks Kraken astar benchmark. Original issue's description: > [turbofan] Remove value numbering from late optimization pass. > > Committed: https://crrev.com/e32535af5a5f4776a58ef434ea77d56528ded427 > Cr-Commit-Position: refs/heads/master@{#41672} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2579273002 Cr-Commit-Position: refs/heads/master@{#41748} Committed: https://chromium.googlesource.com/v8/v8/+/c5ea51259c488572277eced46c4c0149ffe96b56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/pipeline.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jarin
Created Revert of [turbofan] Remove value numbering from late optimization pass.
4 years ago (2016-12-16 09:53:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579273002/1
4 years ago (2016-12-16 09:53:44 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-16 10:20:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c5ea51259c488572277eced46c4c0149ffe...

Powered by Google App Engine
This is Rietveld 408576698