Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2579243003: [counters] Add counter scopes for the Compiler::Analyze phases (Closed)

Created:
4 years ago by Toon Verwaest
Modified:
3 years, 11 months ago
Reviewers:
Camillo Bruni, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] Add counter scopes for the Compiler::Analyze phases BUG= Review-Url: https://codereview.chromium.org/2579243003 Cr-Commit-Position: refs/heads/master@{#42143} Committed: https://chromium.googlesource.com/v8/v8/+/6e17ea901a8cbb276522364d3d7788b64ac63d09

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add more #

Patch Set 3 : Fix up more counters #

Patch Set 4 : Rename to script #

Patch Set 5 : [counters] rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M src/ast/scopes.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 5 chunks +11 lines, -6 lines 0 comments Download
M src/counters.h View 1 2 3 4 1 chunk +9 lines, -5 lines 0 comments Download
M src/parsing/rewriter.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
Camillo Bruni
lgtm https://codereview.chromium.org/2579243003/diff/1/src/counters.h File src/counters.h (right): https://codereview.chromium.org/2579243003/diff/1/src/counters.h#newcode695 src/counters.h:695: V(CompilerDispatcher) \ why no usey?
4 years ago (2016-12-16 15:07:47 UTC) #2
Camillo Bruni
lgtm
4 years ago (2016-12-16 15:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579243003/80001
3 years, 11 months ago (2017-01-09 13:53:46 UTC) #7
rmcilroy
LGTM, thanks. https://codereview.chromium.org/2579243003/diff/80001/src/parsing/rewriter.cc File src/parsing/rewriter.cc (right): https://codereview.chromium.org/2579243003/diff/80001/src/parsing/rewriter.cc#newcode358 src/parsing/rewriter.cc:358: info->isolate(), &RuntimeCallStats::CompileRewriteReturnResult); nit - would it work ...
3 years, 11 months ago (2017-01-09 13:55:27 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 14:22:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/6e17ea901a8cbb276522364d3d7788b64ac...

Powered by Google App Engine
This is Rietveld 408576698