Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2579233002: Merge MemoryCoordinator and MemoryCoordinatorImpl into one class (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, shimazu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge MemoryCoordinator and MemoryCoordinatorImpl into one class We are going to add content::MemoryCoordinator to expose some methods outside content/. As a preparation, merge the current MemoryCoordinator class and its impl class into MemoryCoordinatorImpl to simplify the relationship of classes. In a follow-up CL we will add content::MemoryCoordinator in content/public/browser and make MemoryCoordinatorImpl be a subclass of it. BUG=673216 Committed: https://crrev.com/2cee40a7b7ecbe0737b802f953d10eb39c5eb2df Cr-Commit-Position: refs/heads/master@{#439691}

Patch Set 1 #

Patch Set 2 : Fix android build #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -666 lines) Patch
M content/browser/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/memory/memory_coordinator.h View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
D content/browser/memory/memory_coordinator.cc View 1 2 1 chunk +0 lines, -219 lines 0 comments Download
D content/browser/memory/memory_coordinator_browsertest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.h View 1 2 3 chunks +107 lines, -12 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 1 2 5 chunks +202 lines, -11 lines 0 comments Download
A + content/browser/memory/memory_coordinator_impl_browsertest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 7 chunks +166 lines, -14 lines 0 comments Download
D content/browser/memory/memory_coordinator_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
M content/browser/memory/memory_monitor_android.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/test/memory_coordinator_test_utils.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 32 (23 generated)
bashi
chrisha@, haraken@: PTAL shmazu@: FYI (I won't submit this CL until your https://codereview.chromium.org/2569963002/ is landed)
4 years ago (2016-12-16 05:08:08 UTC) #8
haraken
LGTM on my side
4 years ago (2016-12-16 05:30:54 UTC) #9
bashi
Rebased. +jam@ for content/ review +falken@ for content/browser/service_worker review +michaeln@ for content/browser/dom_storage review
4 years ago (2016-12-19 06:17:42 UTC) #16
falken
sw lgtm
4 years ago (2016-12-19 06:25:29 UTC) #17
jam
lgtm https://codereview.chromium.org/2579233002/diff/40001/content/public/test/memory_coordinator_test_utils.cc File content/public/test/memory_coordinator_test_utils.cc (right): https://codereview.chromium.org/2579233002/diff/40001/content/public/test/memory_coordinator_test_utils.cc#newcode16 content/public/test/memory_coordinator_test_utils.cc:16: &content::MemoryCoordinatorImpl::GetCurrentMemoryState, nit: here and below remove content::
4 years ago (2016-12-19 18:44:39 UTC) #20
bashi
Let me submit this CL as changes in dom_storage is trivial (just removed an #include) ...
4 years ago (2016-12-20 03:09:07 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579233002/60001
4 years ago (2016-12-20 03:09:24 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-20 03:28:47 UTC) #30
commit-bot: I haz the power
4 years ago (2016-12-20 03:31:16 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2cee40a7b7ecbe0737b802f953d10eb39c5eb2df
Cr-Commit-Position: refs/heads/master@{#439691}

Powered by Google App Engine
This is Rietveld 408576698