Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2579213004: [wasm] Fix nondeterministic Win64 failures (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Don't store the result of setjmp #

Patch Set 3 : Store setjmp return value in static volatile #

Patch Set 4 : Remove potentially unneeded volatile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M test/cctest/wasm/wasm-run-utils.h View 1 2 3 5 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Clemens Hammacher
Let's see what the 20 try runs (only selected test cases) say about it.
4 years ago (2016-12-16 12:40:02 UTC) #1
titzer
lgtm
4 years ago (2016-12-16 15:12:40 UTC) #9
ahaas
lgtm
4 years ago (2016-12-16 15:19:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579213004/60001
4 years ago (2016-12-16 15:30:23 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-16 15:32:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/8341b8baf44d194f6477abac2c741132b5d...

Powered by Google App Engine
This is Rietveld 408576698