|
|
Chromium Code Reviews
DescriptionFix typo in JS test code checking for Webcam in browser_test_utils.cc
The typo effectively caused the below tests to not be executed.
After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix.
BUG=674628
TEST=
out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*"
out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*"
out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*"
Committed: https://crrev.com/b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47
Cr-Commit-Position: refs/heads/master@{#439558}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Fix type in JS test code checking for Webcam. BUG= ========== to ========== Fix typo in JS test code checking for Webcam in browser_test_utils.cc The type effectively cause the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" ==========
chfremer@chromium.org changed reviewers: + lunalu@google.com, mcasas@chromium.org, sky@chromium.org
Description was changed from ========== Fix typo in JS test code checking for Webcam in browser_test_utils.cc The type effectively cause the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" ========== to ========== Fix typo in JS test code checking for Webcam in browser_test_utils.cc The typo effectively caused the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" ==========
The CQ bit was checked by chfremer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
mcasas@chromium.org changed reviewers: + avi@chromium.org - sky@chromium.org
lgtm - let's ship it and see the bots. avi@ can you RS this change plz? (-sky@ since he's OOO)
lgtm stampity stamp
The CQ bit was checked by chfremer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482175821188690, "parent_rev":
"376c882c386c00ceec658301c370853c1145ff38", "commit_rev":
"3cfb276c28edb7854bca96be56f7eec1365c640f"}
Message was sent while issue was closed.
Description was changed from ========== Fix typo in JS test code checking for Webcam in browser_test_utils.cc The typo effectively caused the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" ========== to ========== Fix typo in JS test code checking for Webcam in browser_test_utils.cc The typo effectively caused the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" Review-Url: https://codereview.chromium.org/2579183003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix typo in JS test code checking for Webcam in browser_test_utils.cc The typo effectively caused the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" Review-Url: https://codereview.chromium.org/2579183003 ========== to ========== Fix typo in JS test code checking for Webcam in browser_test_utils.cc The typo effectively caused the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" Committed: https://crrev.com/b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47 Cr-Commit-Position: refs/heads/master@{#439558} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47 Cr-Commit-Position: refs/heads/master@{#439558} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
