Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2579183003: Fix typo in JS test code checking for Webcam in browser_test_utils.cc (Closed)

Created:
4 years ago by chfremer
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in JS test code checking for Webcam in browser_test_utils.cc The typo effectively caused the below tests to not be executed. After this CL they will execute, even though only the ImageCapture tests will run on trybots, because the other tests use the MANUAL_* prefix. BUG=674628 TEST= out/Default/content_browsertests --gtest_filter="WebRtcImageCaptureBrowserTest.*" out/Default/content_browsertests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" out/Default/browser_tests --run-manual --gtest_filter="WebRtcWebcamBrowserTest*" Committed: https://crrev.com/b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47 Cr-Commit-Position: refs/heads/master@{#439558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
chfremer
PTAL
4 years ago (2016-12-19 19:25:05 UTC) #8
mcasas
lgtm - let's ship it and see the bots. avi@ can you RS this change ...
4 years ago (2016-12-19 19:26:32 UTC) #10
Avi (use Gerrit)
lgtm stampity stamp
4 years ago (2016-12-19 19:29:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579183003/1
4 years ago (2016-12-19 19:31:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 21:12:11 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-19 21:15:47 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5f5e5f36dc8ca72cf962feb70e9c3c3e2573e47
Cr-Commit-Position: refs/heads/master@{#439558}

Powered by Google App Engine
This is Rietveld 408576698