Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2579163003: [turbofan] Combine family of CallJS() methods into single implementation. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Combine family of CallJS() methods into single implementation. ... by using variadic templates in CodeAssembler. BUG= Review-Url: https://codereview.chromium.org/2579163003 Cr-Commit-Position: refs/heads/master@{#41753} Committed: https://chromium.googlesource.com/v8/v8/+/01408ea6532fb81750ab68729f1c503a7ad71d5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -98 lines) Patch
M src/compiler/code-assembler.h View 3 chunks +6 lines, -18 lines 0 comments Download
M src/compiler/code-assembler.cc View 3 chunks +2 lines, -80 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-16 10:47:45 UTC) #4
Michael Starzinger
LGTM.
4 years ago (2016-12-16 10:53:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579163003/1
4 years ago (2016-12-16 10:59:14 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 11:34:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/01408ea6532fb81750ab68729f1c503a7ad...

Powered by Google App Engine
This is Rietveld 408576698