Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2579103002: [Android] Fix ndk_next gn args in mb_config. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix ndk_next gn args in mb_config. They should be strings. They were not strings. This fixes https://codereview.chromium.org/2572233003/ BUG=668202 TBR=dpranke@chromium.org Committed: https://crrev.com/b03ccd36ba4a48f97afb993312cf0c874021d3ce Cr-Commit-Position: refs/heads/master@{#438877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jbudorick
tbr: small fix for the NDK builders' mb config.
4 years ago (2016-12-15 17:21:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579103002/1
4 years ago (2016-12-15 17:22:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 18:23:17 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b03ccd36ba4a48f97afb993312cf0c874021d3ce Cr-Commit-Position: refs/heads/master@{#438877}
4 years ago (2016-12-15 18:26:21 UTC) #11
Dirk Pranke
4 years ago (2016-12-15 21:55:24 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698