Rename OnAppsUpdated to OnIntentFiltersUpdated

Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try

Committed: https://crrev.com/4af2926f8b00bd4f18eedab66170dbd021624ce6
Cr-Commit-Position: refs/heads/master@{#439008}

[Yusuke Sato, 2016-12-15 16:30:53]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 16:31:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 17:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 17:00:49]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-12-15 18:18:19]

Description was changed from

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

...

BUG=672840
TEST=try
==========

to

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency.

BUG=672840
TEST=try
==========

[Yusuke Sato, 2016-12-15 18:21:59]

Description was changed from

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency.

BUG=672840
TEST=try
==========

to

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

BUG=672840
TEST=try
==========

[Yusuke Sato, 2016-12-15 18:21:59]

yusukes@chromium.org changed reviewers:
+ hidehiko@chromium.org

[Yusuke Sato, 2016-12-15 18:22:22]

PTAL

[Yusuke Sato, 2016-12-15 18:23:34]

yusukes@chromium.org changed reviewers:
+ kinaba@chromium.org

[Yusuke Sato, 2016-12-15 18:23:35]

+kinaba for file_manager/. PTAL.

[Yusuke Sato, 2016-12-15 18:28:47]

Description was changed from

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

BUG=672840
TEST=try
==========

to

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try
==========

[Yusuke Sato, 2016-12-15 18:29:18]

+derat FYI

[Daniel Erat, 2016-12-15 18:43:08]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-12-15 18:43:09]

lgtm

thanks for the heads-up!

https://codereview.chromium.org/2579083002/diff/1/components/arc/arc_service_...
File components/arc/arc_service_manager.h (right):

https://codereview.chromium.org/2579083002/diff/1/components/arc/arc_service_...
components/arc/arc_service_manager.h:31: // Called when app's intent filter is
updated.
nit: maybe "Called when intent filters are added or removed."?

[Yusuke Sato, 2016-12-15 19:28:25]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 19:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-12-15 19:29:16]

https://codereview.chromium.org/2579083002/diff/1/components/arc/arc_service_...
File components/arc/arc_service_manager.h (right):

https://codereview.chromium.org/2579083002/diff/1/components/arc/arc_service_...
components/arc/arc_service_manager.h:31: // Called when app's intent filter is
updated.
On 2016/12/15 18:43:09, Daniel Erat wrote:
> nit: maybe "Called when intent filters are added or removed."?

Thanks, done.

[commit-bot: I haz the power, 2016-12-15 20:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 20:03:50]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2016-12-15 21:23:00]

derat@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Daniel Erat, 2016-12-15 21:23:01]

lgtm

thanks!

[Luis Héctor Chávez, 2016-12-15 21:24:32]

lgtm

[kinaba, 2016-12-16 01:03:20]

lgtm

[hidehiko, 2016-12-16 01:05:36]

lgtm

https://codereview.chromium.org/2579083002/diff/20001/components/arc/intent_h...
File components/arc/intent_helper/arc_intent_helper_observer.h (right):

https://codereview.chromium.org/2579083002/diff/20001/components/arc/intent_h...
components/arc/intent_helper/arc_intent_helper_observer.h:14: virtual
~ArcIntentHelperObserver() = default;
As you're here, could you swap the decl order of the method and dtor?

https://google.github.io/styleguide/cppguide.html#Declaration_Order

[Yusuke Sato, 2016-12-16 01:24:52]

https://codereview.chromium.org/2579083002/diff/20001/components/arc/intent_h...
File components/arc/intent_helper/arc_intent_helper_observer.h (right):

https://codereview.chromium.org/2579083002/diff/20001/components/arc/intent_h...
components/arc/intent_helper/arc_intent_helper_observer.h:14: virtual
~ArcIntentHelperObserver() = default;
On 2016/12/16 01:05:36, hidehiko wrote:
> As you're here, could you swap the decl order of the method and dtor?
> 
> https://google.github.io/styleguide/cppguide.html#Declaration_Order

good catch, done.

[Yusuke Sato, 2016-12-16 01:24:57]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-12-16 01:24:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, lhchavez@chromium.org, derat@chromium.org,
kinaba@chromium.org
Link to the patchset: https://codereview.chromium.org/2579083002/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-12-16 01:26:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 03:42:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481851497895890,
"parent_rev": "87e2bd7bfeb97f9aeb9b2e93a621971f6e80eda9", "commit_rev":
"a98fcf8ec3579af9e3dd69eb69e8d4c133d8d30c"}

[commit-bot: I haz the power, 2016-12-16 03:42:57]

Description was changed from

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try
==========

to

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try

Review-Url: https://codereview.chromium.org/2579083002
==========

[commit-bot: I haz the power, 2016-12-16 03:42:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-16 03:46:34]

Description was changed from

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try

Review-Url: https://codereview.chromium.org/2579083002
==========

to

==========
Rename OnAppsUpdated to OnIntentFiltersUpdated

Previously, ArcIntentHelperBridge::OnIntentFiltersUpdated() called
OnAppsUpdated() for each observer, but this was probably just confusing.
This CL renames the observer method to fix the inconsistency and to
make it easier to maintain the ArcServiceManager::Observer interface.

This is a follow-up CL for
https://codereview.chromium.org/2487623002/.

BUG=672840
TEST=try

Committed: https://crrev.com/4af2926f8b00bd4f18eedab66170dbd021624ce6
Cr-Commit-Position: refs/heads/master@{#439008}
==========

[commit-bot: I haz the power, 2016-12-16 03:46:36]

Patchset 3 (id:??) landed as
https://crrev.com/4af2926f8b00bd4f18eedab66170dbd021624ce6
Cr-Commit-Position: refs/heads/master@{#439008}