Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2579063002: Remove obsolete parameters from spdy_view.html. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
eroman
CC:
chromium-reviews, eroman, arv+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete parameters from spdy_view.html. Remove enable_spdy31, use_alternative_services, npn_protos, and protocol_negotiated parameters from spdy_view.html. These parameters are not generated for a long time now, they only stayed here for compatibility with older netlogs. This CL is a follow-up to the following CLs: https://crrev.com/1268313004 https://crrev.com/1651123002 https://crrev.com/2151643003 https://crrev.com/2229693003 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/737c31017ed6e62138ebb58ac4614e127bd1a9d4 Cr-Commit-Position: refs/heads/master@{#438927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M chrome/browser/resources/net_internals/spdy_view.html View 2 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Bence
eroman@: PTAL. Thank you.
4 years ago (2016-12-15 17:42:32 UTC) #7
eroman
lgtm
4 years ago (2016-12-15 21:07:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579063002/1
4 years ago (2016-12-15 21:18:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 21:25:26 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 21:29:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/737c31017ed6e62138ebb58ac4614e127bd1a9d4
Cr-Commit-Position: refs/heads/master@{#438927}

Powered by Google App Engine
This is Rietveld 408576698