Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2579043002: [wrapper-tracing] Reland: Turn on flag (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, Marcel Hlopko, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 NOTRY=true Committed: https://crrev.com/4b81adefe8d80be06d53b33dd0d5979839596456 Cr-Commit-Position: refs/heads/master@{#439124}

Patch Set 1 #

Patch Set 2 : Adjust expectations for flaky inspector test. See its crbug #

Patch Set 3 : Rebase expctations file #

Patch Set 4 : Rebase expecations file again... #

Messages

Total messages: 41 (28 generated)
Michael Lippautz
PTAL Except the flake I described in the email it should be safe to reland ...
4 years ago (2016-12-16 12:29:41 UTC) #17
haraken
LGTM once the inspector issue is resolved.
4 years ago (2016-12-16 12:30:11 UTC) #18
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-16 12:30:36 UTC) #19
Michael Lippautz
+kbr: fyi, we are giving this another go. The WebGL flake has been resolved. Feel ...
4 years ago (2016-12-16 14:38:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579043002/60001
4 years ago (2016-12-16 14:39:26 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/9499) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-16 14:40:56 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579043002/80001
4 years ago (2016-12-16 14:46:35 UTC) #28
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-16 16:24:24 UTC) #30
Michael Lippautz
FYI: Added NOTRY after running all TRY bots since and rebasing the expectations file.
4 years ago (2016-12-16 16:38:55 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579043002/100001
4 years ago (2016-12-16 16:39:40 UTC) #35
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years ago (2016-12-16 16:45:35 UTC) #38
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4b81adefe8d80be06d53b33dd0d5979839596456 Cr-Commit-Position: refs/heads/master@{#439124}
4 years ago (2016-12-16 16:47:11 UTC) #40
Luis Héctor Chávez
4 years ago (2016-12-16 21:28:04 UTC) #41
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/2587553002/ by lhchavez@chromium.org.

The reason for reverting is: This causes
DirectoryTreeContextMenu/FileManagerBrowserTest.Test to be flaky:
crbug.com/675062.

Powered by Google App Engine
This is Rietveld 408576698