|
|
Created:
4 years ago by Michael Lippautz Modified:
4 years ago CC:
blink-reviews, chromium-reviews, Marcel Hlopko, Ken Russell (switch to Gerrit) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[wrapper-tracing] Reland: Turn on flag
BUG=chromium:468240
NOTRY=true
Committed: https://crrev.com/4b81adefe8d80be06d53b33dd0d5979839596456
Cr-Commit-Position: refs/heads/master@{#439124}
Patch Set 1 #Patch Set 2 : Adjust expectations for flaky inspector test. See its crbug #Patch Set 3 : Rebase expctations file #Patch Set 4 : Rebase expecations file again... #
Messages
Total messages: 41 (28 generated)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [wrapper-tracing] Reland: Turn on flag BUG= ========== to ========== [wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mlippautz@chromium.org changed reviewers: + haraken@chromium.org, jochen@chromium.org
PTAL Except the flake I described in the email it should be safe to reland now. Not sure what to do about it.
LGTM once the inspector issue is resolved.
lgtm
+kbr: fyi, we are giving this another go. The WebGL flake has been resolved. Feel free to revert if you see breakage that you think is related and requires immediate resolving.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2579043002/#ps60001 (title: "Adjust expectations for flaky inspector test. See its crbug")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2579043002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:2232 error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply Patch: third_party/WebKit/LayoutTests/TestExpectations Index: third_party/WebKit/LayoutTests/TestExpectations diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 277acc5c1c924326255b911bdd75e1f5d39ee49b..f05806d7e10f713d5a3eca0996961920c5178d97 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -2232,6 +2232,7 @@ crbug.com/674720 [ Debug Trusty ] http/tests/loading/preload-img-test.html [ Pas # Added 2016-12-16 crbug.com/674858 [ Trusty ] virtual/threaded/printing/offscreencanvas-2d-printing.html [ Pass Failure ] crbug.com/674858 [ Trusty ] virtual/threaded/printing/offscreencanvas-webgl-printing.html [ Pass Failure ] +crbug.com/674917 http/tests/inspector/search/sources-search-scope-many-projects.html [ Pass Failure ] # for Skia DEPS roll crbug.com/674509 compositing/overlap-blending/reflection-opacity-huge.html [ NeedsRebaseline ]
Description was changed from ========== [wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 ========== to ========== [wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 NOTRY=true ==========
FYI: Added NOTRY after running all TRY bots since and rebasing the expectations file.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2579043002/#ps100001 (title: "rebease again...")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481906348689850, "parent_rev": "b42f693c114078a37b58d9f538f0c0e50ec2bb19", "commit_rev": "e0015dab0d81210b6045a01c3e9b827e6ae1502f"}
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 NOTRY=true ========== to ========== [wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 NOTRY=true Review-Url: https://codereview.chromium.org/2579043002 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 NOTRY=true Review-Url: https://codereview.chromium.org/2579043002 ========== to ========== [wrapper-tracing] Reland: Turn on flag BUG=chromium:468240 NOTRY=true Committed: https://crrev.com/4b81adefe8d80be06d53b33dd0d5979839596456 Cr-Commit-Position: refs/heads/master@{#439124} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/4b81adefe8d80be06d53b33dd0d5979839596456 Cr-Commit-Position: refs/heads/master@{#439124}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:100001) has been created in https://codereview.chromium.org/2587553002/ by lhchavez@chromium.org. The reason for reverting is: This causes DirectoryTreeContextMenu/FileManagerBrowserTest.Test to be flaky: crbug.com/675062. |