Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2579023002: [runtime] Improve Object::ToNumber, ToInteger, ToInt32, ToUint32, ToString (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Improve Object::ToNumber, ToInteger, ToInt32, ToUint32, ToString This CL adds inlineable fast-cases for the above conversion functions in objects-inl.h and a slower conversion function in objects.cc. BUG= Review-Url: https://codereview.chromium.org/2579023002 Cr-Commit-Position: refs/heads/master@{#41766} Committed: https://chromium.googlesource.com/v8/v8/+/c0d6939836f5eaf7580715ed58cab6930f3b5692

Patch Set 1 #

Patch Set 2 : fix Uint32 conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -27 lines) Patch
M src/objects.h View 3 chunks +24 lines, -10 lines 0 comments Download
M src/objects.cc View 5 chunks +24 lines, -16 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 20 (16 generated)
Camillo Bruni
PTAL
4 years ago (2016-12-15 15:02:49 UTC) #9
Igor Sheludko
lgtm
4 years ago (2016-12-16 14:05:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579023002/20001
4 years ago (2016-12-16 14:27:49 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-16 14:30:12 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c0d6939836f5eaf7580715ed58cab6930f3...

Powered by Google App Engine
This is Rietveld 408576698