Add Material Components iOS as a dependency.

Add Material Components iOS as a dependency.

BUG=581717
R=rohitrao@chromium.org,sdefresne@chromium.org

Committed: https://crrev.com/15a7ab4d0f394afde5e6165abb8bc6f331f7dfae
Cr-Commit-Position: refs/heads/master@{#438991}

[sdefresne, 2016-12-15 18:13:58]

You need to rebase I think.

https://codereview.chromium.org/2579003003/diff/1/ios/third_party/material_co...
File ios/third_party/material_components_ios/OWNERS (right):

https://codereview.chromium.org/2579003003/diff/1/ios/third_party/material_co...
ios/third_party/material_components_ios/OWNERS:2: rohitrao@google.com
@google.com -> @chromium.org

[lpromero, 2016-12-15 18:26:27]

https://codereview.chromium.org/2579003003/diff/1/ios/third_party/material_co...
File ios/third_party/material_components_ios/OWNERS (right):

https://codereview.chromium.org/2579003003/diff/1/ios/third_party/material_co...
ios/third_party/material_components_ios/OWNERS:2: rohitrao@google.com
On 2016/12/15 18:13:58, sdefresne wrote:
> @google.com -> @chromium.org

Done.

[lpromero, 2016-12-15 18:28:36]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 18:28:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2016-12-15 18:30:18]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 18:30:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2016-12-15 21:27:27]

https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
File ios/third_party/material_components_ios/OWNERS (right):

https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
ios/third_party/material_components_ios/OWNERS:5: # structural changes, please
get a review from an OWNER.
Is this still valid?

[lpromero, 2016-12-15 23:10:17]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-12-15 23:13:27]

lgtm

https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
File ios/third_party/material_components_ios/OWNERS (right):

https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
ios/third_party/material_components_ios/OWNERS:5: # structural changes, please
get a review from an OWNER.
On 2016/12/15 21:27:27, lpromero wrote:
> Is this still valid?

Yeah, any roller will need to add/remove files to keep things green.

[lpromero, 2016-12-15 23:58:24]

The CQ bit was unchecked by lpromero@chromium.org

[lpromero, 2016-12-15 23:58:28]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2016-12-15 23:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 02:29:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481846308494550,
"parent_rev": "ee9bf9770996c68b1ae1167a99b72ebbed2fd958", "commit_rev":
"2c5ce6ec76fe4c2543723f99bb738b0dff50f98e"}

[commit-bot: I haz the power, 2016-12-16 02:30:27]

Description was changed from

==========
Add Material Components iOS as a dependency.

BUG=581717
R=rohitrao@chromium.org,sdefresne@chromium.org
==========

to

==========
Add Material Components iOS as a dependency.

BUG=581717
R=rohitrao@chromium.org,sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2579003003
==========

[commit-bot: I haz the power, 2016-12-16 02:30:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-16 02:31:49]

Description was changed from

==========
Add Material Components iOS as a dependency.

BUG=581717
R=rohitrao@chromium.org,sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2579003003
==========

to

==========
Add Material Components iOS as a dependency.

BUG=581717
R=rohitrao@chromium.org,sdefresne@chromium.org

Committed: https://crrev.com/15a7ab4d0f394afde5e6165abb8bc6f331f7dfae
Cr-Commit-Position: refs/heads/master@{#438991}
==========

[commit-bot: I haz the power, 2016-12-16 02:31:50]

Patchset 4 (id:??) landed as
https://crrev.com/15a7ab4d0f394afde5e6165abb8bc6f331f7dfae
Cr-Commit-Position: refs/heads/master@{#438991}

[sdefresne, 2016-12-16 08:36:40]

lgtm

[Nico, 2017-05-11 16:38:10]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-05-11 16:38:14]

https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
File ios/third_party/material_components_ios/BUILD.gn (right):

https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
ios/third_party/material_components_ios/BUILD.gn:37:
"-Wno-error=deprecated-declarations",
This does not lgtm. We want a silent build, so that warnings carry meaning.
Please use `-Wno-deprecated-declarations` to disable the warning altogether.
Never use -Wno-error=something.

[lpromero, 2017-05-23 11:31:13]

On 2017/05/11 16:38:14, Nico wrote:
>
https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
> File ios/third_party/material_components_ios/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2579003003/diff/60001/ios/third_party/materia...
> ios/third_party/material_components_ios/BUILD.gn:37:
> "-Wno-error=deprecated-declarations",
> This does not lgtm. We want a silent build, so that warnings carry meaning.
> Please use `-Wno-deprecated-declarations` to disable the warning altogether.
> Never use -Wno-error=something.

https://codereview.chromium.org/2897013002/ to address.