Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2578903002: Made -webkit-print-color-adjust property independent. (Closed)

Created:
4 years ago by napper
Modified:
4 years ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made -webkit-print-color-adjust property independent. Made -webkit-print-color-adjust property independent. Also updated independent-inheritance-fast-path.html to include webkitPrintColorAdjust. Also minor cleanup of make_computed_style_base.py, including removing a redundant if and assignment to property_name. Tested using independent-inheritance-fast-path.html. BUG=628043 Committed: https://crrev.com/e316115a42ac56384c89562cd1923014a850290b Cr-Commit-Position: refs/heads/master@{#438797}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
napper
4 years ago (2016-12-15 05:49:49 UTC) #6
sashab
Thanks for that unrelated fix. LGTM
4 years ago (2016-12-15 06:14:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578903002/20001
4 years ago (2016-12-15 09:55:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 09:59:47 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-15 10:03:02 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e316115a42ac56384c89562cd1923014a850290b
Cr-Commit-Position: refs/heads/master@{#438797}

Powered by Google App Engine
This is Rietveld 408576698