Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2578893005: Remove class fields desugaring (Closed)

Created:
4 years ago by Dan Ehrenberg
Modified:
4 years ago
Reviewers:
marja
CC:
petermarshall, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove class fields desugaring This patch removes parser code implementing desugaring for ESnext public and private fields on classes. The desugaring should probably be implemented in the interpreter instead, and more work needs to go into optimization and debugger support. The actual parsing of class fields is left in, as the syntax is relatively stable, and there are strong cctests for the grammar. R=marja BUG=v8:5367 Review-Url: https://codereview.chromium.org/2578893005 Cr-Commit-Position: refs/heads/master@{#41776} Committed: https://chromium.googlesource.com/v8/v8/+/61833f5b9adfc3a19653c37cf27135a373474458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -414 lines) Patch
M src/ast/ast.h View 6 chunks +10 lines, -39 lines 0 comments Download
M src/ast/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/parsing/parser.cc View 10 chunks +6 lines, -308 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/parsing/preparser.h View 3 chunks +0 lines, -17 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Ehrenberg
PTAL
4 years ago (2016-12-16 01:47:43 UTC) #4
marja
lgtm as this is just removing code
4 years ago (2016-12-16 08:44:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578893005/1
4 years ago (2016-12-16 19:50:06 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-16 19:52:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/61833f5b9adfc3a19653c37cf27135a3734...

Powered by Google App Engine
This is Rietveld 408576698