Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2578873004:
Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. (Closed)
DescriptionSimplify by using the same code for didMoveIntoFrameHost and MoveBetween.
As a precursor step for removing event listener properties
prior to moving a node iterator, this CL attempts to simplify
the code in
EventHandlerRegistry::didMoveBetweenFrameHosts()
by having it re-use the
existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While
this doesn't allow simply skimming the old properties off of the old
frameHost, presumably this is still equivalent and efficient enough
given that such moves presumably happen infrequently compared to things
like drawing frames, etc.
BUG=
Committed: https://crrev.com/3d89f7fbae8aa451a891f331f1148de173326e78
Cr-Commit-Position: refs/heads/master@{#439499}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 17 (11 generated)
The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= ========== to ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= ==========
wjmaclean@chromium.org changed reviewers: + bokan@chromium.org
Not sure if this will pass on the bots, but it's worth giving a spin.
Description was changed from ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= ========== to ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties prior to moving a node iterator, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
On 2016/12/16 21:31:37, wjmaclean wrote: > Not sure if this will pass on the bots, but it's worth giving a spin. Failure on android_n5x_swarming_rel seems unrelated (WebSockets failure).
lgtm
The CQ bit was checked by wjmaclean@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482159058051310, "parent_rev":
"209e652d58d8a825eb3f89a0a631c42569a461b9", "commit_rev":
"53a306cd3513f99b583cc1d4ec36039230fbdfab"}
Message was sent while issue was closed.
Description was changed from ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties prior to moving a node iterator, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= ========== to ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties prior to moving a node iterator, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= Review-Url: https://codereview.chromium.org/2578873004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties prior to moving a node iterator, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= Review-Url: https://codereview.chromium.org/2578873004 ========== to ========== Simplify by using the same code for didMoveIntoFrameHost and MoveBetween. As a precursor step for removing event listener properties prior to moving a node iterator, this CL attempts to simplify the code in EventHandlerRegistry::didMoveBetweenFrameHosts() by having it re-use the existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While this doesn't allow simply skimming the old properties off of the old frameHost, presumably this is still equivalent and efficient enough given that such moves presumably happen infrequently compared to things like drawing frames, etc. BUG= Committed: https://crrev.com/3d89f7fbae8aa451a891f331f1148de173326e78 Cr-Commit-Position: refs/heads/master@{#439499} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3d89f7fbae8aa451a891f331f1148de173326e78 Cr-Commit-Position: refs/heads/master@{#439499} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
