Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 2578823002: DevTools: [Persistence] sync resetting of working copy (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Persistence] sync resetting of working copy Currently, the persistence only syncs working copy changes. However, one of the valid change of working copy is its resetting - means that UISourceCode becomes non-dirty again. This patch starts resetting working copy of UISourceCode if its counterpart got into a clean state. BUG=674332 R=dgozman Committed: https://crrev.com/382f1cf54206273d88b368a6ddffe0151816e8e2 Cr-Commit-Position: refs/heads/master@{#438759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
lushnikov
please, take
4 years ago (2016-12-15 00:21:27 UTC) #1
lushnikov
please, take a look*
4 years ago (2016-12-15 00:21:34 UTC) #2
dgozman
lgtm
4 years ago (2016-12-15 04:12:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578823002/1
4 years ago (2016-12-15 05:45:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 05:50:22 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 05:56:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/382f1cf54206273d88b368a6ddffe0151816e8e2
Cr-Commit-Position: refs/heads/master@{#438759}

Powered by Google App Engine
This is Rietveld 408576698