Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2578813002:
MD Settings: Eliminate remaining references to paper-dropdown-menu-light (Closed)
|
Created:
4 years ago by stevenjb Modified:
4 years ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Eliminate remaining references to paper-dropdown-menu-light
BUG=653689
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/32ca522f776a4656163f9ff62c30c7d57d190364
Cr-Commit-Position: refs/heads/master@{#438934}
Patch Set 1 #Patch Set 2 : Remove paper-dropdown-menu-light from polymer_resources.grdp #Patch Set 3 : Rebase #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== MD Settings: Eliminate remaining references to paper-dropdown-menu-light BUG=653689 ========== to ========== MD Settings: Eliminate remaining references to paper-dropdown-menu-light BUG=653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
stevenjb@chromium.org changed reviewers: + dpapad@chromium.org, michaelpg@chromium.org
This removes all remaining references to paper-dropdown-menu-light from Chrome, but we still have references to paper-dropdown-menu in non Settings UI. Should we also remove the paper-dropdown-menu-light entries in ui/webui/resources/polymer_resources.grdp? Will it make any difference to load times?
On 2016/12/15 at 00:22:18, stevenjb wrote: > This removes all remaining references to paper-dropdown-menu-light from Chrome, but we still have references to paper-dropdown-menu in non Settings UI. > > Should we also remove the paper-dropdown-menu-light entries in ui/webui/resources/polymer_resources.grdp? Will it make any difference to load times? LGTM I am in favor of removing from the grdp file if no one is using paper-drodown-menu-light anymore. Not just because of the possibly small load time gain, but we also have a script to detect unused polymer elements (https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/find_unused_ele...), which would probably (assuming is working correctly), find paper-dropdown-menu-ligth as unused next time we roll polymer.
On 2016/12/15 00:22:18, stevenjb wrote: > This removes all remaining references to paper-dropdown-menu-light from Chrome, > but we still have references to paper-dropdown-menu in non Settings UI. > > Should we also remove the paper-dropdown-menu-light entries in > ui/webui/resources/polymer_resources.grdp? Will it make any difference to load > times? Yes, that should have been removed when we stopped using it. Otherwise it's being included in the .pak file which increases size (and indirectly impacts performance I guess).
Removed from polymer_resources.grdp. PTAL
The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
lgtm On 2016/12/15 01:57:42, dpapad wrote: > On 2016/12/15 at 00:22:18, stevenjb wrote: > > This removes all remaining references to paper-dropdown-menu-light from > Chrome, but we still have references to paper-dropdown-menu in non Settings UI. > > > > Should we also remove the paper-dropdown-menu-light entries in > ui/webui/resources/polymer_resources.grdp? Will it make any difference to load > times? > > LGTM > I am in favor of removing from the grdp file if no one is using > paper-drodown-menu-light anymore. Not just because of the possibly small load > time gain, but we also have a script to detect unused polymer elements > (https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/find_unused_ele...), > which would probably (assuming is working correctly), find > paper-dropdown-menu-ligth as unused next time we roll polymer. No, actually find_unused_elements.py only finds unused bower components -- meaning, *directories* in components-chromium that are not included from chrome or ui. As long as any file in the directory is included from chrome or ui, the entire directory will "pass". This inspired me to try to make a simple shell script to find unused files... I'll see what I can do.
The CQ bit was checked by stevenjb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org, michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/2578813002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by stevenjb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481838228374130,
"parent_rev": "7ab13f659a1f1eb4c207b25ac350ba013703cfc3", "commit_rev":
"4df7fa28cd8293ce3da7e659c0b50b884fcd346f"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Eliminate remaining references to paper-dropdown-menu-light BUG=653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Eliminate remaining references to paper-dropdown-menu-light BUG=653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2578813002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Eliminate remaining references to paper-dropdown-menu-light BUG=653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2578813002 ========== to ========== MD Settings: Eliminate remaining references to paper-dropdown-menu-light BUG=653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/32ca522f776a4656163f9ff62c30c7d57d190364 Cr-Commit-Position: refs/heads/master@{#438934} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/32ca522f776a4656163f9ff62c30c7d57d190364 Cr-Commit-Position: refs/heads/master@{#438934} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
