Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 2578793002: Remove unused m_OtfFontData (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused m_OtfFontData. In turn, this makes CFX_BinaryBuf::AttachData() unused. Review-Url: https://codereview.chromium.org/2578793002 Committed: https://pdfium.googlesource.com/pdfium/+/72a22025ec4402178cd0b27239bf77cf3a953949

Patch Set 1 #

Patch Set 2 : AttachData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M core/fxcrt/fx_basic.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M core/fxcrt/fx_basic_buffer.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M core/fxge/fx_font.h View 2 chunks +0 lines, -6 lines 0 comments Download
M core/fxge/ge/cfx_font.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, dead code.
4 years ago (2016-12-14 23:29:46 UTC) #2
dsinclair
lgtm
4 years ago (2016-12-15 03:51:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578793002/20001
4 years ago (2016-12-15 03:51:12 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 04:10:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/72a22025ec4402178cd0b27239bf77cf3a95...

Powered by Google App Engine
This is Rietveld 408576698