[EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h" (1/3)

[EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789
Committed: https://crrev.com/17c7368db5e14c05733b204bbf79e73998810d4b
Cr-Commit-Position: refs/heads/master@{#438979}

[chongz, 2016-12-14 21:07:09]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 21:07:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 22:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:47:51]

Dry run: This issue passed the CQ dry run.

[chongz, 2016-12-14 23:32:18]

Description was changed from

==========
Move and rename |enum EditorCommandSource| to |enum class CommandSource|

BUG=673789
==========

to

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the 1/3 patch of supporting |CommandSource| in |CompositeEditCommand|.

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

[chongz, 2016-12-14 23:42:25]

Description was changed from

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the 1/3 patch of supporting |CommandSource| in |CompositeEditCommand|.

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

to

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

[chongz, 2016-12-14 23:42:36]

Description was changed from

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

to

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
 |CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

[chongz, 2016-12-14 23:42:45]

Description was changed from

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
 |CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

to

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

[chongz, 2016-12-14 23:45:56]

Description was changed from

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

BUG=673789
==========

to

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789
==========

[chongz, 2016-12-15 00:38:14]

chongz@chromium.org changed reviewers:
+ xiaochengh@chromium.org

[chongz, 2016-12-15 00:38:15]

xiaochengh@ This is the first sub-patch of the |CommandSource| CL, PTAL, thanks!

[Xiaocheng, 2016-12-15 02:24:57]

lgtm with a nit on naming. I should have mentioned that in the last round...

https://codereview.chromium.org/2578753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2578753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:45: enum
class CommandSource { MenuOrKeyBinding, Dom };
Please rename them as kMenuOrKeyBinding and kDOM.

The blink naming convention requires kCamelCase for enum class members:

https://www.chromium.org/blink/coding-style#TOC-Names

Besides, it seems that all appearances of DOM in blink code base is either 'dom'
or 'DOM'. Let's follow that.

[Xiaocheng, 2016-12-15 02:29:17]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-12-15 02:29:17]

+tkent for owner's review.

[tkent, 2016-12-15 02:32:42]

> 1. Renamed |EditorCommandSource| => |CommandSource|

Why do you rename it?

[Xiaocheng, 2016-12-15 02:38:29]

On 2016/12/15 at 02:32:42, tkent wrote:
> > 1. Renamed |EditorCommandSource| => |CommandSource|
> 
> Why do you rename it?

This patch is a preparation of making CompositeEditCommand store a command
source. For this purpose, the name "EditorCommandSource" becomes inaccurate
since it now applies to not only editor commands.

[tkent, 2016-12-15 03:10:36]

On 2016/12/15 at 02:38:29, xiaochengh wrote:
> On 2016/12/15 at 02:32:42, tkent wrote:
> > > 1. Renamed |EditorCommandSource| => |CommandSource|
> > 
> > Why do you rename it?
> 
> This patch is a preparation of making CompositeEditCommand store a command
source. For this purpose, the name "EditorCommandSource" becomes inaccurate
since it now applies to not only editor commands.

It's still editing-related.  I'm afraid the name CommandSource is too generic.

[chongz, 2016-12-15 22:22:01]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:22:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2016-12-15 22:52:32]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[chongz, 2016-12-15 22:52:42]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-12-15 22:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2016-12-15 23:53:11]

tkent@ PTAL again, thanks!

> It's still editing-related.  I'm afraid the name CommandSource is too generic.

I've renamed it to |EditCommandSource| since it primary used by
|CompositeEditCommand| but not just |Editor|. Does that work or do you have
other names in mind?

https://codereview.chromium.org/2578753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2578753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:45: enum
class CommandSource { MenuOrKeyBinding, Dom };
On 2016/12/15 02:24:57, Xiaocheng wrote:
> Please rename them as kMenuOrKeyBinding and kDOM.
> 
> The blink naming convention requires kCamelCase for enum class members:
> 
> https://www.chromium.org/blink/coding-style#TOC-Names
> 
> Besides, it seems that all appearances of DOM in blink code base is either
'dom'
> or 'DOM'. Let's follow that.

Done.

[tkent, 2016-12-16 00:01:53]

lgtm.

Please update the CL description.

[commit-bot: I haz the power, 2016-12-16 00:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:34:52]

Dry run: This issue passed the CQ dry run.

[chongz, 2016-12-16 00:41:39]

Description was changed from

==========
[CommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |CommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |CommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789
==========

to

==========
[EditCommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789
==========

[chongz, 2016-12-16 00:42:30]

On 2016/12/16 00:01:53, tkent wrote:
> lgtm.
> 
> Please update the CL description.

Done.

[chongz, 2016-12-16 00:42:38]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-12-16 00:42:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2578753002/#ps40001
(title: "Xiaocheng and tkent's review: Rename to |EditCommandSource| and use
kCamelCase")

[commit-bot: I haz the power, 2016-12-16 00:43:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:50:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481848958743840,
"parent_rev": "9fc70cc5fd62da94c9f47322d2f0d552e0c0ea35", "commit_rev":
"06c0ebbcc51c1160fcda0a6d6c47ac8079050530"}

[commit-bot: I haz the power, 2016-12-16 01:51:17]

Description was changed from

==========
[EditCommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789
==========

to

==========
[EditCommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789

Review-Url: https://codereview.chromium.org/2578753002
==========

[commit-bot: I haz the power, 2016-12-16 01:51:18]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-16 01:54:08]

Description was changed from

==========
[EditCommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789

Review-Url: https://codereview.chromium.org/2578753002
==========

to

==========
[EditCommandSource] Rename and move |EditorCommandSource| to
"CompositeEditCommand.h" (1/3)

This is the sub-patch (1/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

This CL:
1. Renamed |EditorCommandSource| => |EditCommandSource|
2. Changed type |enum| => |enum class|
3. Moved from "Editor.h" => "CompositeEditCommand.h"

This CL shouldn't have any behavior change.

BUG=673789

Committed: https://crrev.com/17c7368db5e14c05733b204bbf79e73998810d4b
Cr-Commit-Position: refs/heads/master@{#438979}
==========

[commit-bot: I haz the power, 2016-12-16 01:54:09]

Patchset 2 (id:??) landed as
https://crrev.com/17c7368db5e14c05733b204bbf79e73998810d4b
Cr-Commit-Position: refs/heads/master@{#438979}

[chongz, 2017-01-17 18:03:24]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2636963003/ by chongz@chromium.org.

The reason for reverting is: We want to revert all CLs and start over the
refactor process, see:
https://crbug.com/673789..