Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257873002: DevTools: do not use internals for highlight testing, use protocol instead. (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

DevTools: do not use internals for highlight testing, use protocol instead. R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172643

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -73 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-node.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight-node-scaled.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-node-scroll.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/highlight-svg-root.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight-svg-root-zoomed.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorController.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 2 chunks +3 lines, -12 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
6 years, 8 months ago (2014-04-25 12:27:06 UTC) #1
apavlov
lgtm
6 years, 8 months ago (2014-04-25 12:30:04 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 8 months ago (2014-04-25 14:50:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/257873002/20001
6 years, 8 months ago (2014-04-25 14:51:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 15:35:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-25 15:35:03 UTC) #6
pfeldman
6 years, 8 months ago (2014-04-25 16:30:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 manually as r172643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698