Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 257873002: DevTools: do not use internals for highlight testing, use protocol instead. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorOverlay.h ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorOverlay.cpp
diff --git a/Source/core/inspector/InspectorOverlay.cpp b/Source/core/inspector/InspectorOverlay.cpp
index 2d1b2246b0f473052f95333a02937068d089d86b..522204b02d4aaeead087fe736ea53120844822af 100644
--- a/Source/core/inspector/InspectorOverlay.cpp
+++ b/Source/core/inspector/InspectorOverlay.cpp
@@ -327,18 +327,6 @@ void InspectorOverlay::drawOutline(GraphicsContext* context, const LayoutRect& r
drawOutlinedQuad(context, outlineRect, Color(), color);
}
-void InspectorOverlay::getHighlight(Highlight* highlight) const
-{
- if (!m_highlightNode && !m_highlightQuad)
- return;
-
- highlight->type = HighlightTypeRects;
- if (m_highlightNode)
- buildNodeHighlight(m_highlightNode.get(), m_nodeHighlightConfig, highlight);
- else
- buildQuadHighlight(m_page, *m_highlightQuad, m_quadHighlightConfig, highlight);
-}
-
void InspectorOverlay::resize(const IntSize& size)
{
m_size = size;
@@ -690,6 +678,9 @@ void InspectorOverlay::freePage()
}
m_overlayChromeClient.clear();
m_timer.stop();
+
+ // This will clear internal structures and issue update to the client. Safe to call last.
+ hideHighlight();
}
void InspectorOverlay::startedRecordingProfile()
« no previous file with comments | « Source/core/inspector/InspectorOverlay.h ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698