chrome/browser/ui/webui/options/clear_browser_data_handler.cc - Issue 2578723002: Reduce BrowsingDataRemover's dependencies on Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 2578723002: Reduce BrowsingDataRemover's dependencies on Chrome (Closed)

Patch Set: A new callsite appeared through rebase - fixed the compilation error. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

index b12d01e42ab1d93bd2d4d86f2a6491b0dd7786bd..cce1050044ad491b26ede19a2c1fc51862f3ed93 100644

--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc

@@ -319,9 +319,12 @@ void ClearBrowserDataHandler::HandleClearBrowserData(

remover_->AddObserver(this);

int period_selected =

prefs->GetInteger(browsing_data::prefs::kDeleteTimePeriod);

+ browsing_data::TimePeriod time_period =

+ static_cast<browsing_data::TimePeriod>(period_selected);

+ browsing_data::RecordDeletionForPeriod(time_period);

remover_->RemoveAndReply(

- BrowsingDataRemover::Period(

- static_cast<browsing_data::TimePeriod>(period_selected)),

+ browsing_data::CalculateBeginDeleteTime(time_period),

+ browsing_data::CalculateEndDeleteTime(time_period),

remove_mask, origin_mask, this);

// Store the clear browsing data time. Next time the clear browsing data