chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc - Issue 2578723002: Reduce BrowsingDataRemover's dependencies on Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 2578723002: Reduce BrowsingDataRemover's dependencies on Chrome (Closed)

Patch Set: A new callsite appeared through rebase - fixed the compilation error. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_handler.cc ('k') | components/browsing_data/core/browsing_data_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

index a2e2b3ab706bcfdf3b66f3f0d243970f945de2df..8bc52fea67f6740fd95a81a2e9d2b4bcd57021a6 100644

--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

@@ -206,9 +206,12 @@ void ClearBrowsingDataHandler::HandleClearBrowsingData(

remover,

base::Bind(&ClearBrowsingDataHandler::OnClearingTaskFinished,

base::Unretained(this), webui_callback_id));

+ browsing_data::TimePeriod time_period =

+ static_cast<browsing_data::TimePeriod>(period_selected);

+ browsing_data::RecordDeletionForPeriod(time_period);

remover->RemoveAndReply(

- BrowsingDataRemover::Period(

- static_cast<browsing_data::TimePeriod>(period_selected)),

+ browsing_data::CalculateBeginDeleteTime(time_period),

+ browsing_data::CalculateEndDeleteTime(time_period),

remove_mask, origin_mask, task_observer_.get());

}