Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2578713002: Add logging to TestDriver (Closed)

Created:
4 years ago by Robert Ogden
Modified:
4 years ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging to TestDriver BUG=669956 Committed: https://crrev.com/bb07db2852eb2de9f625d0f0365f9683ba9a90ba Cr-Commit-Position: refs/heads/master@{#438849}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -7 lines) Patch
M tools/chrome_proxy/webdriver/common.py View 1 19 chunks +82 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Robert Ogden
4 years ago (2016-12-14 20:32:24 UTC) #3
RyanSturm
lgtm % 2 nits I agree with all of the info/debug/error decisions :) https://codereview.chromium.org/2578713002/diff/1/tools/chrome_proxy/webdriver/common.py File ...
4 years ago (2016-12-14 23:04:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578713002/20001
4 years ago (2016-12-15 16:43:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 16:54:52 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bb07db2852eb2de9f625d0f0365f9683ba9a90ba Cr-Commit-Position: refs/heads/master@{#438849}
4 years ago (2016-12-15 16:57:28 UTC) #12
Robert Ogden
4 years ago (2016-12-15 17:15:09 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/2578713002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2578713002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:22: 
On 2016/12/14 23:04:28, Ryan Sturm wrote:
> remove extra vertical whitespace.

Done.

https://codereview.chromium.org/2578713002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:58: 'ERROR', 'CRIT'], default='ERROR',
help='The logging level for log '
On 2016/12/14 23:04:28, Ryan Sturm wrote:
> s/level/threshold/ or "verbosity"

Done.

Powered by Google App Engine
This is Rietveld 408576698