Do not call lower() on domains set from DOM after canonicalization

Do not call lower() on domains set from DOM after canonicalization

We already canonicalize the domain using normal host canonicalization.
Calling lower() actually yields non-canonical domains if the domain has
percent encoded characters (which canonicalize to use uppercase).

BUG=none

Committed: https://crrev.com/5d603f5dff8fbdf0c57b57af8652188db129d53a
Cr-Commit-Position: refs/heads/master@{#438836}

[Charlie Harrison, 2016-12-14 17:43:50]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 17:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-12-14 18:10:30]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 18:10:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-12-14 18:55:20]

csharrison@chromium.org changed reviewers:
+ mkwst@chromium.org

[Charlie Harrison, 2016-12-14 18:55:20]

Mike: here is a tiny bit of fallout from the patch that removed a bunch of calls
to lower(). PTAL?

[commit-bot: I haz the power, 2016-12-14 19:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 19:53:15]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-12-15 14:53:56]

Makes sense to me, thanks for following up on this!

LGTM.

[Charlie Harrison, 2016-12-15 15:58:29]

On 2016/12/15 14:53:56, Mike West (slow) wrote:
> Makes sense to me, thanks for following up on this!
> 
> LGTM.

No problem, TBH I should have caught this originally with more robust tests.

[Charlie Harrison, 2016-12-15 15:58:33]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-12-15 15:58:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 16:05:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481817513773480,
"parent_rev": "dad05c3042280bb2d613e0018cd91dbac3a571cf", "commit_rev":
"cc490d6eb58ec4f99c908655f3984069b92f710d"}

[commit-bot: I haz the power, 2016-12-15 16:06:17]

Description was changed from

==========
Do not call lower() on domains set from DOM after canonicalization

We already canonicalize the domain using normal host canonicalization.
Calling lower() actually yields non-canonical domains if the domain has
percent encoded characters (which canonicalize to use uppercase).

BUG=none
==========

to

==========
Do not call lower() on domains set from DOM after canonicalization

We already canonicalize the domain using normal host canonicalization.
Calling lower() actually yields non-canonical domains if the domain has
percent encoded characters (which canonicalize to use uppercase).

BUG=none

Review-Url: https://codereview.chromium.org/2578653002
==========

[commit-bot: I haz the power, 2016-12-15 16:06:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 16:10:29]

Description was changed from

==========
Do not call lower() on domains set from DOM after canonicalization

We already canonicalize the domain using normal host canonicalization.
Calling lower() actually yields non-canonical domains if the domain has
percent encoded characters (which canonicalize to use uppercase).

BUG=none

Review-Url: https://codereview.chromium.org/2578653002
==========

to

==========
Do not call lower() on domains set from DOM after canonicalization

We already canonicalize the domain using normal host canonicalization.
Calling lower() actually yields non-canonical domains if the domain has
percent encoded characters (which canonicalize to use uppercase).

BUG=none

Committed: https://crrev.com/5d603f5dff8fbdf0c57b57af8652188db129d53a
Cr-Commit-Position: refs/heads/master@{#438836}
==========

[commit-bot: I haz the power, 2016-12-15 16:10:30]

Patchset 2 (id:??) landed as
https://crrev.com/5d603f5dff8fbdf0c57b57af8652188db129d53a
Cr-Commit-Position: refs/heads/master@{#438836}