Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2578633002: Revert of [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image (Closed)

Created:
4 years ago by sugoi1
Modified:
4 years ago
CC:
chromium-reviews, piman+watch_chromium.org, Yang Gu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image (patchset #5 id:80001 of https://codereview.chromium.org/2570823002/ ) Reason for revert: Broke Linux NVidia GPU FYI bot. See: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29 Original issue's description: > [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting > > BUG=672719 > TEST=conformance2/rendering/read-draw-when-missing-image.html > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73 > Cr-Commit-Position: refs/heads/master@{#438477} TBR=zmo@chromium.org,kbr@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672719 Committed: https://crrev.com/a90f25c0439895a5c7dcaa9861a3dc06c9b9ad3a Cr-Commit-Position: refs/heads/master@{#438524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -37 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +1 line, -31 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
sugoi1
4 years ago (2016-12-14 15:52:34 UTC) #2
Created Revert of [Command buffer]: Generate INVALID_OPERATION if designated
attachments in read fb miss image

Powered by Google App Engine
This is Rietveld 408576698