Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 257863004: Revert of Ensure that modal dialogs from subframes can be cleaned up correctly. (Closed)

Created:
6 years, 7 months ago by robliao
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Revert of Ensure that modal dialogs from subframes can be cleaned up correctly. (https://codereview.chromium.org/255543009/) Reason for revert: Causes leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2046/steps/browser_tests/logs/SadTabCancelsSubframeDialogs Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x56973b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x52464ce in IPC::SyncMessage::GenerateReply(IPC::Message const*) ipc/ipc_sync_message.cc:99 #2 0x9f6ec47 in Tuple4 ipc/ipc_message_utils.h:877 #3 0x9f6ec47 in bool FrameHostMsg_RunJavaScriptMessage::DispatchDelayReply\u003Ccontent::RenderFrameHostImpl, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)>(IPC::Message const*, content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)) content/common/frame_messages.h:545 #4 0x9f6b9d3 in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) content/browser/frame_host/render_frame_host_impl.cc:287 #5 0xa1185d9 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_process_host_impl.cc:1346 #6 0x5239eec in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ipc/ipc_channel_proxy.cc:269 #7 0x3256fbf in Run base/callback.h:401 #8 0x3256fbf in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:450 #9 0x3258e35 in DeferOrRunPendingTask base/message_loop/message_loop.cc:462 #10 0x3258e35 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:576 #11 0x32fab87 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:270 #12 0x3290314 in base::RunLoop::Run() base/run_loop.cc:49 #13 0xc55c305 in content::RunThisRunLoop(base::RunLoop*) content/public/test/test_utils.cc:103 #14 0xc55e252 in operator-> content/public/test/test_utils.cc:165 #15 0xc55e252 in content::WindowedNotificationObserver::Wait() content/public/test/test_utils.cc:225 #16 0x31af7c1 in ui_test_utils::WaitForAppModalDialog() chrome/test/base/ui_test_utils.cc:342 #17 0x19c1ed8 in BrowserTest_SadTabCancelsSubframeDialogs_Test::RunTestOnMainThread() chrome/browser/ui/browser_browsertest.cc:585 #18 0x31996b8 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:419 Original issue's description: > Ensure that modal dialogs from subframes can be cleaned up correctly. > > BUG=366510 > TEST=See bug comment 7 for repro steps. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266638 TBR=avi@chromium.org,sky@chromium.org,creis@chromium.org NOTREECHECKS=true NOTRY=true BUG=366510 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -51 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robliao
Created Revert of Ensure that modal dialogs from subframes can be cleaned up correctly.
6 years, 7 months ago (2014-04-28 21:47:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/257863004/1
6 years, 7 months ago (2014-04-28 21:49:12 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 21:50:52 UTC) #3
Message was sent while issue was closed.
Change committed as 266669

Powered by Google App Engine
This is Rietveld 408576698