content/browser/renderer_host/render_view_host_impl.cc - Issue 257863004: Revert of Ensure that modal dialogs from subframes can be cleaned up correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 257863004: Revert of Ensure that modal dialogs from subframes can be cleaned up correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index faef12a1c264775fd88778fd9e68805f4dc25f00..243b0a2c0c65d243c6029214cd2c09f7f4824b1f 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1190,9 +1190,7 @@

render_view_termination_status_ =

static_cast<base::TerminationStatus>(status);

- // Reset frame tree state associated with this process. This must happen

- // before RenderViewTerminated because observers expect the subframes of any

- // affected frames to be cleared first.

+ // Reset frame tree state associated with this process.

delegate_->GetFrameTree()->RenderProcessGone(this);

// Our base class RenderWidgetHost needs to reset some stuff.

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »