Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2578513002: Expose BudgetState interface to Workers. (Closed)

Created:
4 years ago by harkness
Modified:
4 years ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose BudgetState interface to Workers. The proposed specification has the BudgetState interface exposed to Workers. This brings the implementation in sync with that spec. This also expands the interface tests to validate that the interface is exposed. BUG=672111 Committed: https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c Cr-Commit-Position: refs/heads/master@{#438497}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 11 (5 generated)
harkness
4 years ago (2016-12-14 11:32:05 UTC) #2
Peter Beverloo
lgtm https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js File third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js (right): https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js#newcode60 third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:60: BudgetState.prototype.hasOwnProperty('time'); Something that crossed my mind - we ...
4 years ago (2016-12-14 11:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578513002/1
4 years ago (2016-12-14 11:39:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 13:08:11 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c Cr-Commit-Position: refs/heads/master@{#438497}
4 years ago (2016-12-14 13:10:28 UTC) #10
harkness
4 years ago (2016-12-14 13:48:58 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:60:
BudgetState.prototype.hasOwnProperty('time');
On 2016/12/14 11:37:08, Peter Beverloo wrote:
> Something that crossed my mind - we have no tests in either dedicated or
shared
> workers right now. It'd be cool to at least have some sort of smoke test to
> verify that something works.

Sure, I can look into adding something for one or both of those.

Powered by Google App Engine
This is Rietveld 408576698