Expose BudgetState interface to Workers.

Expose BudgetState interface to Workers.

The proposed specification has the BudgetState interface exposed to
Workers. This brings the implementation in sync with that spec.

This also expands the interface tests to validate that the interface is
exposed.

BUG=672111
Committed: https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c
Cr-Commit-Position: refs/heads/master@{#438497}

[harkness, 2016-12-14 11:32:05]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-12-14 11:37:08]

lgtm

https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:60:
BudgetState.prototype.hasOwnProperty('time');
Something that crossed my mind - we have no tests in either dedicated or shared
workers right now. It'd be cool to at least have some sort of smoke test to
verify that something works.

[harkness, 2016-12-14 11:39:13]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2016-12-14 11:39:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 13:07:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481715553211560, "parent_rev":
"ad31abc6443086f2d2aab8d49a05591f2a2db5a9", "commit_rev":
"4918b0af4e61c4a0b93fc71eba73bdcb9178b21e"}

[commit-bot: I haz the power, 2016-12-14 13:08:10]

Description was changed from

==========
Expose BudgetState interface to Workers.

The proposed specification has the BudgetState interface exposed to
Workers. This brings the implementation in sync with that spec.

This also expands the interface tests to validate that the interface is
exposed.

BUG=672111
==========

to

==========
Expose BudgetState interface to Workers.

The proposed specification has the BudgetState interface exposed to
Workers. This brings the implementation in sync with that spec.

This also expands the interface tests to validate that the interface is
exposed.

BUG=672111

Review-Url: https://codereview.chromium.org/2578513002
==========

[commit-bot: I haz the power, 2016-12-14 13:08:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 13:10:27]

Description was changed from

==========
Expose BudgetState interface to Workers.

The proposed specification has the BudgetState interface exposed to
Workers. This brings the implementation in sync with that spec.

This also expands the interface tests to validate that the interface is
exposed.

BUG=672111

Review-Url: https://codereview.chromium.org/2578513002
==========

to

==========
Expose BudgetState interface to Workers.

The proposed specification has the BudgetState interface exposed to
Workers. This brings the implementation in sync with that spec.

This also expands the interface tests to validate that the interface is
exposed.

BUG=672111

Committed: https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c
Cr-Commit-Position: refs/heads/master@{#438497}
==========

[commit-bot: I haz the power, 2016-12-14 13:10:28]

Patchset 1 (id:??) landed as
https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c
Cr-Commit-Position: refs/heads/master@{#438497}

[harkness, 2016-12-14 13:48:58]

https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/2578513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:60:
BudgetState.prototype.hasOwnProperty('time');
On 2016/12/14 11:37:08, Peter Beverloo wrote:
> Something that crossed my mind - we have no tests in either dedicated or
shared
> workers right now. It'd be cool to at least have some sort of smoke test to
> verify that something works.

Sure, I can look into adding something for one or both of those.