Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2578493002: Add a skeleton of idle time spell checker (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a skeleton of idle time spell checker This patch introduces a new class IdleSpellCheckCallback for implementing most of the idle time spell checker. The new class currently has only a skeleton implementing the state machine as specified in the design doc. It does not contain any real spell checking logic, and is not exposed to any other class, yet. Follow-up patches will do that. Design doc: https://docs.google.com/document/d/1vo71cnlGOqOuXyy1zjzXSlUIjG7GsWgRjqmkrq1g5hk/edit?usp=sharing BUG=517298 Committed: https://crrev.com/71334324b1fce43df19e2941f43ea44f266600f0 Cr-Commit-Position: refs/heads/master@{#438492}

Patch Set 1 #

Patch Set 2 : typo fix #

Patch Set 3 : Fix usage of Timer::startOneShot #

Total comments: 2

Patch Set 4 : Use kCamelCase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp View 1 2 3 1 chunk +159 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-14 08:40:16 UTC) #9
tkent
lgtm https://codereview.chromium.org/2578493002/diff/40001/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h File third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h (right): https://codereview.chromium.org/2578493002/diff/40001/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h#newcode45 third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h:45: Inactive, Please prepend 'k' to each items. Reference: ...
4 years ago (2016-12-14 08:45:50 UTC) #10
Xiaocheng
Thanks for the review. Committing with the enum class members prefixed with 'k'. https://codereview.chromium.org/2578493002/diff/40001/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h File ...
4 years ago (2016-12-14 09:08:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578493002/60001
4 years ago (2016-12-14 09:08:21 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-14 12:55:31 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-14 12:58:00 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/71334324b1fce43df19e2941f43ea44f266600f0
Cr-Commit-Position: refs/heads/master@{#438492}

Powered by Google App Engine
This is Rietveld 408576698