Add support to detect unregistered AV products in system profile.

Add support to detect unregistered AV products in system profile.

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
TEST=manual - see https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjwlY/edit

Committed: https://crrev.com/4b6a82030b3d331ce561fc781b3861af99c89b24
Cr-Commit-Position: refs/heads/master@{#438641}

[Will Harris, 2016-12-14 01:48:53]

Description was changed from

==========
Add support to detect unregistered AV products in system profile.

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
==========

to

==========
Add support to detect unregistered AV products in system profile.

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
TEST=manual - see
https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjw...
==========

[Will Harris, 2016-12-14 01:50:08]

wfh@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Will Harris, 2016-12-14 01:51:14]

PTAL

[rkaplow, 2016-12-14 20:51:33]

lgtm

https://codereview.chromium.org/2578453002/diff/1/chrome/browser/metrics/anti...
File chrome/browser/metrics/antivirus_metrics_provider_win.h (right):

https://codereview.chromium.org/2578453002/diff/1/chrome/browser/metrics/anti...
chrome/browser/metrics/antivirus_metrics_provider_win.h:83: static void
MaybeAddUnregisteredAntiVirusProducts(
nit - would be consistant in naming between fill and add

[Will Harris, 2016-12-14 20:57:16]

On 2016/12/14 20:51:33, rkaplow wrote:
> lgtm
> 
>
https://codereview.chromium.org/2578453002/diff/1/chrome/browser/metrics/anti...
> File chrome/browser/metrics/antivirus_metrics_provider_win.h (right):
> 
>
https://codereview.chromium.org/2578453002/diff/1/chrome/browser/metrics/anti...
> chrome/browser/metrics/antivirus_metrics_provider_win.h:83: static void
> MaybeAddUnregisteredAntiVirusProducts(
> nit - would be consistant in naming between fill and add

This was deliberately chosen because fill will totally fill (replace) the vector
while add adds to it...

[Will Harris, 2016-12-14 20:57:20]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:57:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:53:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481749040870290, "parent_rev":
"7132f737f83a03c56726e3510004817da60227e9", "commit_rev":
"8b2e3e9e41bc97a890d6e4eb6c1d1aee7856a705"}

[commit-bot: I haz the power, 2016-12-14 21:53:47]

Description was changed from

==========
Add support to detect unregistered AV products in system profile.

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
TEST=manual - see
https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjw...
==========

to

==========
Add support to detect unregistered AV products in system profile.

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
TEST=manual - see
https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjw...

Review-Url: https://codereview.chromium.org/2578453002
==========

[commit-bot: I haz the power, 2016-12-14 21:53:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 21:56:07]

Description was changed from

==========
Add support to detect unregistered AV products in system profile.

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
TEST=manual - see
https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjw...

Review-Url: https://codereview.chromium.org/2578453002
==========

to

==========
Add support to detect unregistered AV products in system profile.

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
TEST=manual - see
https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjw...

Committed: https://crrev.com/4b6a82030b3d331ce561fc781b3861af99c89b24
Cr-Commit-Position: refs/heads/master@{#438641}
==========

[commit-bot: I haz the power, 2016-12-14 21:56:08]

Patchset 1 (id:??) landed as
https://crrev.com/4b6a82030b3d331ce561fc781b3861af99c89b24
Cr-Commit-Position: refs/heads/master@{#438641}