Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2578443002: Refresh appearance of omnibox results when native theme changes. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh appearance of omnibox results when native theme changes. Previous to this patch, the render texts were created just once. In some cases that was before the view was actually added to a widget hierarchy and therefore GetNativeTheme returned the wrong thing. This only affects GTK theme mode because on all other platforms, there's only ever one NativeTheme. (Incognito does use a different NativeTheme as well but this only affected suggestions which we don't provide in incognito.) BUG=672226 Committed: https://crrev.com/cfd026f99e1868040b970891ba75d9394c5b8efa Cr-Commit-Position: refs/heads/master@{#438418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Evan Stade
4 years ago (2016-12-14 01:31:46 UTC) #3
Peter Kasting
LGTM
4 years ago (2016-12-14 02:45:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578443002/1
4 years ago (2016-12-14 02:47:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 03:48:55 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-14 03:51:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfd026f99e1868040b970891ba75d9394c5b8efa
Cr-Commit-Position: refs/heads/master@{#438418}

Powered by Google App Engine
This is Rietveld 408576698