Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2578433002: Revert of Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID (patchset #11 id:190001 of https://codereview.chromium.org/2547483002/ ) Reason for revert: LiveEdit is broken in some cases. Original issue's description: > Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID > > Now that SharedFunctionInfos have a unique ID (and the IDs are dense), > we can use them as an index into an array, instead of using a > WeakFixedArray where we have to do a linear scan. > > Hooking up liveedit is a bit more involved, see > https://docs.google.com/presentation/d/1FtNa3U7WsF5bPhY9uGoJG5Y9hnz5VBDabfOWpb4unWI/edit > for an overview > > BUG=v8:5589 > R=verwaest@chromium.org,jgruber@chromium.org > > Committed: https://crrev.com/6595e7405769dc9d49e9568d61485efc6d468baf > Cr-Commit-Position: refs/heads/master@{#41600} TBR=jgruber@chromium.org,verwaest@chromium.org,yangguo@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5589, chromium:673950 NOPRESUBMIT=true Committed: https://crrev.com/3dea2c83541af5c0f65044c4224f15d919254a4c Cr-Commit-Position: refs/heads/master@{#41684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -266 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler.cc View 6 chunks +16 lines, -24 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug.cc View 3 chunks +21 lines, -14 lines 0 comments Download
M src/debug/liveedit.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/debug/liveedit.cc View 6 chunks +13 lines, -33 lines 0 comments Download
M src/debug/liveedit.js View 6 chunks +13 lines, -24 lines 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/js/promise.js View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 6 chunks +14 lines, -27 lines 0 comments Download
M src/objects.cc View 4 chunks +60 lines, -85 lines 0 comments Download
M src/objects-inl.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/parsing/parse-info.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/parsing/test-parse-decision.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kozy
Created Revert of Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID
4 years ago (2016-12-14 01:10:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578433002/1
4 years ago (2016-12-14 01:10:45 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30553)
4 years ago (2016-12-14 01:15:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578433002/1
4 years ago (2016-12-14 01:56:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 02:04:19 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 02:05:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dea2c83541af5c0f65044c4224f15d919254a4c
Cr-Commit-Position: refs/heads/master@{#41684}

Powered by Google App Engine
This is Rietveld 408576698