Update paint property subtrees on paint offset changes

Update paint property subtrees on paint offset changes

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7896f0f683f503acd6bcb05efd90644f11266128
Cr-Commit-Position: refs/heads/master@{#439055}

[pdr., 2016-12-16 03:22:23]

Description was changed from

==========
Update paint property subtrees on paint offset changes

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
==========

to

==========
Update paint property subtrees on paint offset changes

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-12-16 03:23:05]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[pdr., 2016-12-16 03:24:09]

https://codereview.chromium.org/2578393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2578393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:928:
context.forceSubtreeUpdate = true;
This is the main change in this patch. Instead of using
object.setNeedsPaintPropertyUpdate(), we force the entire subtree to be updated.

[pdr., 2016-12-16 03:24:13]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 03:25:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-12-16 03:25:50]

lgtm

[Xianzhu, 2016-12-16 04:21:02]

lgtm

[commit-bot: I haz the power, 2016-12-16 05:27:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:27:13]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[pdr., 2016-12-16 05:45:25]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:46:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 07:04:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481867125563160, "parent_rev":
"498c4c0a2cc918df8fdc18bb3dbd2be1fe29bfbf", "commit_rev":
"96ad15671c3955e94b67d7aa75fc6f3e01808454"}

[commit-bot: I haz the power, 2016-12-16 07:04:58]

Description was changed from

==========
Update paint property subtrees on paint offset changes

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update paint property subtrees on paint offset changes

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2578393002
==========

[commit-bot: I haz the power, 2016-12-16 07:04:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 07:07:22]

Description was changed from

==========
Update paint property subtrees on paint offset changes

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2578393002
==========

to

==========
Update paint property subtrees on paint offset changes

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7896f0f683f503acd6bcb05efd90644f11266128
Cr-Commit-Position: refs/heads/master@{#439055}
==========

[commit-bot: I haz the power, 2016-12-16 07:07:22]

Patchset 1 (id:??) landed as
https://crrev.com/7896f0f683f503acd6bcb05efd90644f11266128
Cr-Commit-Position: refs/heads/master@{#439055}