Inline RecordBooleanPrefValue to LogCleanShutdown.

Inline RecordBooleanPrefValue to LogCleanShutdown.

BUG=

Committed: https://crrev.com/6d34116bac8495a14d479e26ddadf83563ab0bd9
Cr-Commit-Position: refs/heads/master@{#439576}

[Steven Holte, 2016-12-16 03:03:45]

holte@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2016-12-16 17:33:53]

https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
File components/metrics/metrics_service.cc (right):

https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
components/metrics/metrics_service.cc:1219:
local_state_->SetBoolean(prefs::kStabilitySessionEndCompleted, end_completed);
doesn't this need to be before RecordCurrentState?

[Steven Holte, 2016-12-16 20:03:24]

https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
File components/metrics/metrics_service.cc (right):

https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
components/metrics/metrics_service.cc:1219:
local_state_->SetBoolean(prefs::kStabilitySessionEndCompleted, end_completed);
On 2016/12/16 17:33:53, rkaplow wrote:
> doesn't this need to be before RecordCurrentState?

To keep it the behavior exactly identical, I've put the RecordCurrentState back.

RecordCurrentState only records the current time in another pref, so calling it
twice in this function doesn't seem useful.  I'm not sure that is needed even
once, since nothing appears to read that preference, but maybe omaha does?

[rkaplow, 2016-12-19 16:47:32]

lgtm

https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
File components/metrics/metrics_service.cc (right):

https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
components/metrics/metrics_service.cc:1219:
local_state_->SetBoolean(prefs::kStabilitySessionEndCompleted, end_completed);
On 2016/12/16 20:03:24, Steven Holte wrote:
> On 2016/12/16 17:33:53, rkaplow wrote:
> > doesn't this need to be before RecordCurrentState?
> 
> To keep it the behavior exactly identical, I've put the RecordCurrentState
back.
> 
> RecordCurrentState only records the current time in another pref, so calling
it
> twice in this function doesn't seem useful.  I'm not sure that is needed even
> once, since nothing appears to read that preference, but maybe omaha does?

Ok, in that case can just clean it up.

To your point that no one seems to be using it, jar seemed to think so too:
https://codesearch.chromium.org/chromium/src/components/metrics/metrics_servi...

[Steven Holte, 2016-12-19 20:30:54]

On 2016/12/19 16:47:32, rkaplow wrote:
> lgtm
> 
>
https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
> File components/metrics/metrics_service.cc (right):
> 
>
https://codereview.chromium.org/2578363003/diff/1/components/metrics/metrics_...
> components/metrics/metrics_service.cc:1219:
> local_state_->SetBoolean(prefs::kStabilitySessionEndCompleted, end_completed);
> On 2016/12/16 20:03:24, Steven Holte wrote:
> > On 2016/12/16 17:33:53, rkaplow wrote:
> > > doesn't this need to be before RecordCurrentState?
> > 
> > To keep it the behavior exactly identical, I've put the RecordCurrentState
> back.
> > 
> > RecordCurrentState only records the current time in another pref, so calling
> it
> > twice in this function doesn't seem useful.  I'm not sure that is needed
even
> > once, since nothing appears to read that preference, but maybe omaha does?
> 
> Ok, in that case can just clean it up.
> 
> To your point that no one seems to be using it, jar seemed to think so too:
>
https://codesearch.chromium.org/chromium/src/components/metrics/metrics_servi...

I'll create a follow up CL to delete unused prefs.

[Steven Holte, 2016-12-19 20:30:58]

The CQ bit was checked by holte@chromium.org

[commit-bot: I haz the power, 2016-12-19 20:32:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:42:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482179458488590,
"parent_rev": "fc1d58305b4f577ca0579611e629a03232e7bcc4", "commit_rev":
"3792a70a703d11910cfa157df4b32ec3810bf386"}

[commit-bot: I haz the power, 2016-12-19 21:43:10]

Description was changed from

==========
Inline RecordBooleanPrefValue to LogCleanShutdown.

BUG=
==========

to

==========
Inline RecordBooleanPrefValue to LogCleanShutdown.

BUG=

Review-Url: https://codereview.chromium.org/2578363003
==========

[commit-bot: I haz the power, 2016-12-19 21:43:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-19 21:47:18]

Description was changed from

==========
Inline RecordBooleanPrefValue to LogCleanShutdown.

BUG=

Review-Url: https://codereview.chromium.org/2578363003
==========

to

==========
Inline RecordBooleanPrefValue to LogCleanShutdown.

BUG=

Committed: https://crrev.com/6d34116bac8495a14d479e26ddadf83563ab0bd9
Cr-Commit-Position: refs/heads/master@{#439576}
==========

[commit-bot: I haz the power, 2016-12-19 21:47:19]

Patchset 2 (id:??) landed as
https://crrev.com/6d34116bac8495a14d479e26ddadf83563ab0bd9
Cr-Commit-Position: refs/heads/master@{#439576}