a11y: Add a11y information to views::Tab and manually ignore its a11y children.

ui/views/controls/tabbed_pane/tabbed_pane.h

Index: ui/views/controls/tabbed_pane/tabbed_pane.h
diff --git a/ui/views/controls/tabbed_pane/tabbed_pane.h b/ui/views/controls/tabbed_pane/tabbed_pane.h
index 4ff3c6922bd1c88733c943f7e2fa833d70e1e662..4b40b1df1f73ab99d1543db74a1e8f85d1d0f35c 100644
--- a/ui/views/controls/tabbed_pane/tabbed_pane.h
+++ b/ui/views/controls/tabbed_pane/tabbed_pane.h
@@ -60,12 +60,11 @@ class VIEWS_EXPORT TabbedPane : public View {
  private:
   friend class FocusTraversalTest;
   friend class Tab;
+  friend class TabbedPaneMacAccessibilityTest;

[tapted, 2017/01/06 04:25:11]

this should have a views::test:: namespace on it. It will need forward-declare
as well (it currently gets a views:: one since it's implicitly declared here in
a views { namespace)

[Patti Lor, 2017/01/09 22:39:27]

Done.

   friend class TabStrip;
   FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, AddAndSelect);
   FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, ArrowKeyBindings);
-
-  // Get the Tab (the tabstrip view, not its content) at the valid |index|.
-  Tab* GetTabAt(int index);

[tapted, 2017/01/06 04:25:11]

huh. I guess this got removed at some point and the declaration was left in. To
do it in the test files, it looks like we can do

Tab* TestHarnessWithFriendAccess::GetTabAt(int index) {
  return static_cast<Tab*>(tabbed_pane_->tab_strip_->child_at(index));
}

There's a comment on TabbedPane::tab_strip_ which suggests the static casting is
"ok"

[Patti Lor, 2017/01/09 22:39:27]

To do this, I also had to move the class declaration for TabStrip into
tabbed_pane.h, let me know if that's not OK.

+  FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, SelectTabWithAccessibleAction);
 
   // Get the Tab (the tabstrip view, not its content) at the selected index.
   Tab* GetSelectedTab();
@@ -121,6 +120,8 @@ class Tab : public View {
   void OnGestureEvent(ui::GestureEvent* event) override;
   gfx::Size GetPreferredSize() const override;
   const char* GetClassName() const override;
+  void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
+  bool HandleAccessibleAction(const ui::AXActionData& action_data) override;
   void OnFocus() override;
   void OnBlur() override;
   bool OnKeyPressed(const ui::KeyEvent& event) override;