a11y: Add a11y information to views::Tab and manually ignore its a11y children.

ui/views/controls/tabbed_pane/tabbed_pane.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TABBED_PANE_TABBED_PANE_H_
 #define UI_VIEWS_CONTROLS_TABBED_PANE_TABBED_PANE_H_
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
@@ skipping 42 matching lines @@
   // Selects |tab| (the tabstrip view, not its content) if it is valid.
   void SelectTab(Tab* tab);
 
   // Overridden from View:
   gfx::Size GetPreferredSize() const override;
   const char* GetClassName() const override;
 
  private:
   friend class FocusTraversalTest;
   friend class Tab;
+  friend class TabbedPaneMacAccessibilityTest;

[tapted, 2017/01/06 04:25:11]

this should have a views::test:: namespace on it. It will need forward-declare
as well (it currently gets a views:: one since it's implicitly declared here in
a views { namespace)

[Patti Lor, 2017/01/09 22:39:27]

Done.

   friend class TabStrip;
   FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, AddAndSelect);
   FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, ArrowKeyBindings);
-
-  // Get the Tab (the tabstrip view, not its content) at the valid |index|.
-  Tab* GetTabAt(int index);

[tapted, 2017/01/06 04:25:11]

huh. I guess this got removed at some point and the declaration was left in. To
do it in the test files, it looks like we can do

Tab* TestHarnessWithFriendAccess::GetTabAt(int index) {
  return static_cast<Tab*>(tabbed_pane_->tab_strip_->child_at(index));
}

There's a comment on TabbedPane::tab_strip_ which suggests the static casting is
"ok"

[Patti Lor, 2017/01/09 22:39:27]

To do this, I also had to move the class declaration for TabStrip into
tabbed_pane.h, let me know if that's not OK.

+  FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, SelectTabWithAccessibleAction);
 
   // Get the Tab (the tabstrip view, not its content) at the selected index.
   Tab* GetSelectedTab();
 
   // Returns the content View of the currently selected Tab.
   View* GetSelectedTabContentView();
 
   // Moves the selection by |delta| tabs, where negative delta means leftwards
   // and positive delta means rightwards. Returns whether the selection could be
   // moved by that amount; the only way this can fail is if there is only one
@@ skipping 35 matching lines @@
   bool selected() const { return contents_->visible(); }
   void SetSelected(bool selected);
 
   // Overridden from View:
   bool OnMousePressed(const ui::MouseEvent& event) override;
   void OnMouseEntered(const ui::MouseEvent& event) override;
   void OnMouseExited(const ui::MouseEvent& event) override;
   void OnGestureEvent(ui::GestureEvent* event) override;
   gfx::Size GetPreferredSize() const override;
   const char* GetClassName() const override;
+  void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
+  bool HandleAccessibleAction(const ui::AXActionData& action_data) override;
   void OnFocus() override;
   void OnBlur() override;
   bool OnKeyPressed(const ui::KeyEvent& event) override;
 
  protected:
   Label* title() { return title_; }
 
   // Called whenever |tab_state_| changes.
   virtual void OnStateChanged();
 
@@ skipping 12 matching lines @@
   TabState tab_state_;
   // The content view associated with this tab.
   View* contents_;
 
   DISALLOW_COPY_AND_ASSIGN(Tab);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TABBED_PANE_TABBED_PANE_H_