Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2578273002:
Support hermetic Xcode compilation with use_xcode_clang. (Closed)
|
Created:
4 years ago by justincohen Modified:
4 years ago CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport hermetic Xcode compilation with use_xcode_clang.
iOS builds can set use_xcode_clang = true and use_system_xcode = false when
chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc
BUG=669094
Committed: https://crrev.com/c360dbf9da64cbf1c6b2d63e87aab8eda61dd424
Cr-Commit-Position: refs/heads/master@{#439028}
Patch Set 1 #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== More env_wrapper BUG= ========== to ========== Support hermetic Xcode compliation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG= ==========
Description was changed from ========== Support hermetic Xcode compliation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG= ========== to ========== Support hermetic Xcode compilation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG= ==========
justincohen@chromium.org changed reviewers: + erikchen@chromium.org
ptal!
lgtm
On 2016/12/16 00:54:48, erikchen wrote: > lgtm add associated crbug.
The CQ bit was checked by justincohen@chromium.org to run a CQ dry run
Description was changed from ========== Support hermetic Xcode compilation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG= ========== to ========== Support hermetic Xcode compilation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG=669094 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
justincohen@chromium.org changed reviewers: + brettw@chromium.org, dpranke@google.com
+dpranke@ or brettw@ for OWNERS
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481861140424290, "parent_rev":
"c7e7587dbdb21e1e8dde4bcbdc80eded8c12e7f4", "commit_rev":
"1c874d0df8f5ce82482f97111cf0c3a40190f895"}
Message was sent while issue was closed.
Description was changed from ========== Support hermetic Xcode compilation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG=669094 ========== to ========== Support hermetic Xcode compilation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG=669094 Review-Url: https://codereview.chromium.org/2578273002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Support hermetic Xcode compilation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG=669094 Review-Url: https://codereview.chromium.org/2578273002 ========== to ========== Support hermetic Xcode compilation with use_xcode_clang. iOS builds can set use_xcode_clang = true and use_system_xcode = false when chromium clang is broken. This requires prepending DEVELOPER_DIR to clang/clang++, etc BUG=669094 Committed: https://crrev.com/c360dbf9da64cbf1c6b2d63e87aab8eda61dd424 Cr-Commit-Position: refs/heads/master@{#439028} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c360dbf9da64cbf1c6b2d63e87aab8eda61dd424 Cr-Commit-Position: refs/heads/master@{#439028} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
