Add constructor for MediaStreamAudioDestinationNode

Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html

Committed: https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17
Cr-Commit-Position: refs/heads/master@{#439833}

[Raymond Toy, 2016-12-15 19:47:35]

Description was changed from

==========
Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html
==========

to

==========
Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html
==========

[Raymond Toy, 2016-12-15 19:47:46]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 19:48:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 21:31:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 21:31:41]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-12-15 22:02:43]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-12-15 22:02:44]

PTAL

[Raymond Toy, 2016-12-19 17:46:55]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 17:47:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:01:10]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hongchan, 2016-12-19 18:29:55]

lgtm with nit

https://codereview.chromium.org/2578243002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html
(right):

https://codereview.chromium.org/2578243002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html:8:
<script src="../resources/audio-testing.js"></script>
Why do we need this?

[Raymond Toy, 2016-12-19 18:33:39]

https://codereview.chromium.org/2578243002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html
(right):

https://codereview.chromium.org/2578243002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html:8:
<script src="../resources/audio-testing.js"></script>
On 2016/12/19 18:29:55, hongchan wrote:
> Why do we need this?

You mean instead of audit.js?

audionodeoptions.js uses Should and I didn't want to convert all the existing
tests to use audit.js instead of audio-testing.js.

[Raymond Toy, 2016-12-19 18:49:46]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2016-12-19 18:49:47]

tkent: PTAL as API owner.  We missed this constructor when adding all the
(other) constructors in issue 626449.

[tkent, 2016-12-19 23:35:02]

lgtm

https://codereview.chromium.org/2578243002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
(right):

https://codereview.chromium.org/2578243002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp:173:
if (!node)
|new| operator never returns nullptr. This check is unnecessary.

[hongchan, 2016-12-19 23:40:37]

https://codereview.chromium.org/2578243002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html
(right):

https://codereview.chromium.org/2578243002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html:8:
<script src="../resources/audio-testing.js"></script>
On 2016/12/19 18:33:38, Raymond Toy wrote:
> On 2016/12/19 18:29:55, hongchan wrote:
> > Why do we need this?
> 
> You mean instead of audit.js?
> 
> audionodeoptions.js uses Should and I didn't want to convert all the existing
> tests to use audit.js instead of audio-testing.js.

Acknowledged.

[Raymond Toy, 2016-12-19 23:44:37]

rtoy@chromium.org changed reviewers:
+ mkwst@chromium.org

[Raymond Toy, 2016-12-19 23:44:38]

mkwst@chromium.org: Please review changes in 

histograms.xml

[haraken, 2016-12-20 00:07:01]

On 2016/12/19 23:44:38, Raymond Toy wrote:
> mailto:mkwst@chromium.org: Please review changes in 
> 
> histograms.xml

histograms LGTM

[Raymond Toy, 2016-12-20 15:13:38]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-12-20 15:13:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org, tkent@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2578243002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-20 15:13:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 17:23:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482246818776680,
"parent_rev": "83674f20c17cc8226eeb84e760ec2fd7125b504d", "commit_rev":
"fbbf777fc76634df2d62155574a47e341294a136"}

[commit-bot: I haz the power, 2016-12-20 17:24:20]

Description was changed from

==========
Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html
==========

to

==========
Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html

Review-Url: https://codereview.chromium.org/2578243002
==========

[commit-bot: I haz the power, 2016-12-20 17:24:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-20 17:26:38]

Description was changed from

==========
Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html

Review-Url: https://codereview.chromium.org/2578243002
==========

to

==========
Add constructor for MediaStreamAudioDestinationNode

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html

Committed: https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17
Cr-Commit-Position: refs/heads/master@{#439833}
==========

[commit-bot: I haz the power, 2016-12-20 17:26:39]

Patchset 5 (id:??) landed as
https://crrev.com/7b308a54ce405471a43e12ea7a65952439127d17
Cr-Commit-Position: refs/heads/master@{#439833}