Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Issue 2578233003: [heap] Explicitly clear mark bits when writing filler for left and right trimming. (Closed)

Created:
4 years ago by Hannes Payer (out of office)
Modified:
4 years ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Explicitly clear mark bits when writing filler for left and right trimming. Since left and right trimming may install a lot of one pointer filler maps, it may still make sense to clear the freed-up black area to speed up sweeping. BUG= Review-Url: https://codereview.chromium.org/2578233003 Cr-Commit-Position: refs/heads/master@{#41811} Committed: https://chromium.googlesource.com/v8/v8/+/1c763e004cae568eebb9d2eb5888f013292e8c76

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : turn off for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -24 lines) Patch
M src/heap/heap.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M src/heap/heap.cc View 1 7 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Hannes Payer (out of office)
4 years ago (2016-12-19 15:52:52 UTC) #13
Michael Lippautz
lgtm
4 years ago (2016-12-19 16:01:10 UTC) #14
ulan
lgtm
4 years ago (2016-12-19 16:04:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578233003/40001
4 years ago (2016-12-19 16:05:02 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-19 16:07:06 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/1c763e004cae568eebb9d2eb5888f013292...

Powered by Google App Engine
This is Rietveld 408576698