Remove ActiveScriptWrappableBase::m_scriptWrappable

Remove ActiveScriptWrappableBase::m_scriptWrappable

Thanks to Sigbjorn's CL (https://codereview.chromium.org/2577053002/),
we can now obtain a pointer to ScriptWrappable from ActiveScriptWrappable.
This CL removes ActiveScriptWrappableBase::m_scriptWrappable and
reduces sizeof(void*) from each ActiveScriptWrappable object.

BUG=

Committed: https://crrev.com/206fee6c2a7ddb33c400a56adda7f53bf62157c2
Cr-Commit-Position: refs/heads/master@{#439091}

[haraken, 2016-12-16 05:19:07]

Description was changed from

==========
Remove ActiveScriptWrappableBase::m_scriptWrappable

Now the pointer is redundant because we can implement
ActiveScriptWrappable::toScriptWrappable
using a template magic.

BUG=
==========

to

==========
Remove ActiveScriptWrappableBase::m_scriptWrappable

Thanks to Sigbjorn's CL (https://codereview.chromium.org/2577053002/),
we can now obtain a pointer to ScriptWrappable from ActiveScriptWrappable.
This CL removes ActiveScriptWrappableBase::m_scriptWrappable and
reduces sizeof(void*) from each ActiveScriptWrappable object.

BUG=
==========

[haraken, 2016-12-16 05:19:23]

haraken@chromium.org changed reviewers:
+ mlippautz@chromium.org, sigbjornf@opera.com

[haraken, 2016-12-16 05:19:24]

PTAL

[sof, 2016-12-16 06:36:24]

a well spotted improvement, lgtm from my side.

https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h (right):

https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h:47:
ActiveScriptWrappable() : ActiveScriptWrappableBase() {}
can be removed.

https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/MessagePort.cpp (right):

https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/MessagePort.cpp:54: :
ActiveScriptWrappable(),
It could be tedious change to make, but just remove all calls to the default
constructor?

[haraken, 2016-12-16 06:53:05]

On 2016/12/16 06:36:24, sof wrote:
> a well spotted improvement, lgtm from my side.
> 
>
https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
(right):
> 
>
https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h:47:
> ActiveScriptWrappable() : ActiveScriptWrappableBase() {}
> can be removed.

This is needed, right?

 
>
https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/MessagePort.cpp (right):
> 
>
https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/MessagePort.cpp:54: :
> ActiveScriptWrappable(),
> It could be tedious change to make, but just remove all calls to the default
> constructor?

Done.

[sof, 2016-12-16 07:28:57]

On 2016/12/16 06:53:05, haraken wrote:
> On 2016/12/16 06:36:24, sof wrote:
> > a well spotted improvement, lgtm from my side.
> > 
> >
>
https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
> (right):
> > 
> >
>
https://codereview.chromium.org/2578193004/diff/40001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h:47:
> > ActiveScriptWrappable() : ActiveScriptWrappableBase() {}
> > can be removed.
> 
> This is needed, right?
> 

I'm most likely missing some aspect, but I would expect the compiler to
synthesize it.

Fine style to explicitly define though, reduce it to "ActiveScriptWrappable()
{}"?

[sof, 2016-12-16 07:29:08]

https://codereview.chromium.org/2578193004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLImageElement.cpp (right):

https://codereview.chromium.org/2578193004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLImageElement.cpp:91: 
nit: empty lines snuck during the search & replace, in a couple of files (the
ones "git cl format" didn't reformat..?)

[haraken, 2016-12-16 07:39:25]

> Fine style to explicitly define though, reduce it to "ActiveScriptWrappable()
{}"?

Done. "ActiveScriptWrappable() {}" seems needed to make the compiler happy.

On 2016/12/16 07:29:08, sof wrote:
>
https://codereview.chromium.org/2578193004/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/HTMLImageElement.cpp (right):
> 
>
https://codereview.chromium.org/2578193004/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/HTMLImageElement.cpp:91: 
> nit: empty lines snuck during the search & replace, in a couple of files (the
> ones "git cl format" didn't reformat..?)

Fixed.

[haraken, 2016-12-16 07:39:34]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-12-16 07:39:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2578193004/#ps80001
(title: "temp")

[commit-bot: I haz the power, 2016-12-16 07:39:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2016-12-16 10:26:58]

lgtm

(ActiveScriptWrappable() = default; would also work I guess ;))

[commit-bot: I haz the power, 2016-12-16 11:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 11:42:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-12-16 11:43:46]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-16 11:43:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 12:16:24]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481888626490090,
"parent_rev": "f40be051b3f319b35876ef1ebdfd458d4cdf99d9", "commit_rev":
"7fc211bfdd05bc513ce1b0922600cbdb8847abbc"}

[commit-bot: I haz the power, 2016-12-16 12:16:53]

Description was changed from

==========
Remove ActiveScriptWrappableBase::m_scriptWrappable

Thanks to Sigbjorn's CL (https://codereview.chromium.org/2577053002/),
we can now obtain a pointer to ScriptWrappable from ActiveScriptWrappable.
This CL removes ActiveScriptWrappableBase::m_scriptWrappable and
reduces sizeof(void*) from each ActiveScriptWrappable object.

BUG=
==========

to

==========
Remove ActiveScriptWrappableBase::m_scriptWrappable

Thanks to Sigbjorn's CL (https://codereview.chromium.org/2577053002/),
we can now obtain a pointer to ScriptWrappable from ActiveScriptWrappable.
This CL removes ActiveScriptWrappableBase::m_scriptWrappable and
reduces sizeof(void*) from each ActiveScriptWrappable object.

BUG=

Review-Url: https://codereview.chromium.org/2578193004
==========

[commit-bot: I haz the power, 2016-12-16 12:16:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-16 12:18:41]

Description was changed from

==========
Remove ActiveScriptWrappableBase::m_scriptWrappable

Thanks to Sigbjorn's CL (https://codereview.chromium.org/2577053002/),
we can now obtain a pointer to ScriptWrappable from ActiveScriptWrappable.
This CL removes ActiveScriptWrappableBase::m_scriptWrappable and
reduces sizeof(void*) from each ActiveScriptWrappable object.

BUG=

Review-Url: https://codereview.chromium.org/2578193004
==========

to

==========
Remove ActiveScriptWrappableBase::m_scriptWrappable

Thanks to Sigbjorn's CL (https://codereview.chromium.org/2577053002/),
we can now obtain a pointer to ScriptWrappable from ActiveScriptWrappable.
This CL removes ActiveScriptWrappableBase::m_scriptWrappable and
reduces sizeof(void*) from each ActiveScriptWrappable object.

BUG=

Committed: https://crrev.com/206fee6c2a7ddb33c400a56adda7f53bf62157c2
Cr-Commit-Position: refs/heads/master@{#439091}
==========

[commit-bot: I haz the power, 2016-12-16 12:18:43]

Patchset 5 (id:??) landed as
https://crrev.com/206fee6c2a7ddb33c400a56adda7f53bf62157c2
Cr-Commit-Position: refs/heads/master@{#439091}