Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2578183002: Merged: [Interpreter] Allocate registers used as call arguments on-demand. (Closed)

Created:
4 years ago by rmcilroy
Modified:
4 years ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, oth, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: [Interpreter] Allocate registers used as call arguments on-demand. Revision: ae741d042c834d2296769e04c27d6b2d4f6e469b BUG=chromium:672027 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mythria@chromium.org Review-Url: https://codereview.chromium.org/2578183002 . Cr-Commit-Position: refs/branch-heads/5.6@{#56} Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014} Committed: https://chromium.googlesource.com/v8/v8/+/57845f979120057a4b965b4b8b4f5d585151c9f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -71 lines) Patch
M src/interpreter/bytecode-generator.h View 3 chunks +8 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 10 chunks +68 lines, -44 lines 0 comments Download
M src/interpreter/bytecode-register.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-register-allocator.h View 1 chunk +21 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyCall.golden View 1 chunk +37 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TopLevelObjectLiterals.golden View 2 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/ignition/regress-672027.js View 1 chunk +17 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-register-allocator-unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rmcilroy
4 years ago (2016-12-15 17:22:47 UTC) #1
rmcilroy
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years ago (2016-12-15 17:22:49 UTC) #2
rmcilroy
This needed a bit of modification to merge. PTAL thanks.
4 years ago (2016-12-15 17:24:08 UTC) #3
mythria
lgtm. Thanks, Mythri
4 years ago (2016-12-16 08:57:36 UTC) #4
rmcilroy
4 years ago (2016-12-16 11:00:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57845f979120057a4b965b4b8b4f5d585151c9f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698