Add GetOriginalRequestURL() to NavigationItem interface.

Add GetOriginalRequestURL() to NavigationItem interface.

This is part of the ongoing effort to move functionality from
CRWSessionEntry into NavigationItem.

BUG=674905, 454984
Review-Url: https://codereview.chromium.org/2578173005
Cr-Commit-Position: refs/heads/master@{#445607}
Committed: https://chromium.googlesource.com/chromium/src/+/5c3f6c83745f372982c6bb5d6d877d490033116e

[kkhorimoto, 2016-12-16 21:58:56]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-16 22:18:18]

lgtm. Could you please add a unit test for getter, setter and copy constructor.
Thanks!

https://codereview.chromium.org/2578173005/diff/1/ios/web/navigation/crw_sess...
File ios/web/navigation/crw_session_entry.mm (left):

https://codereview.chromium.org/2578173005/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.mm:81: self.originalUrl =
_navigationItem->GetURL();
Do we need to do this?:
|_navigationItem->SetOriginalRequestURL(_navigationItem->GetURL());|

At least until we audit all initWithNavigationItems: places and make sure that
original URL is properly set there.

[kkhorimoto, 2017-01-21 02:41:29]

https://codereview.chromium.org/2578173005/diff/1/ios/web/navigation/crw_sess...
File ios/web/navigation/crw_session_entry.mm (left):

https://codereview.chromium.org/2578173005/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.mm:81: self.originalUrl =
_navigationItem->GetURL();
On 2016/12/16 22:18:18, Eugene But wrote:
> Do we need to do this?:
> |_navigationItem->SetOriginalRequestURL(_navigationItem->GetURL());|
> 
> At least until we audit all initWithNavigationItems: places and make sure that
> original URL is properly set there.

This line is no longer necessary, as the original request URLs are copied in the
NavigationItem copy constructor.

[kkhorimoto, 2017-01-21 02:41:33]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-01-21 02:41:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2578173005/#ps20001
(title: "added test")

[commit-bot: I haz the power, 2017-01-21 02:42:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 02:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 02:49:20]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[kkhorimoto, 2017-01-23 22:07:05]

kkhorimoto@chromium.org changed reviewers:
+ rohitrao@chromium.org

[kkhorimoto, 2017-01-23 22:07:05]

+ rohit for Tab OWNERS.

[kkhorimoto, 2017-01-24 01:52:37]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-01-24 01:52:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2578173005/#ps40001
(title: "fix callers")

[commit-bot: I haz the power, 2017-01-24 01:53:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 02:24:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485222757622820,
"parent_rev": "e2908d7f6608b9aa345105e99762112078c17ed3", "commit_rev":
"5c3f6c83745f372982c6bb5d6d877d490033116e"}

[commit-bot: I haz the power, 2017-01-24 02:24:47]

Description was changed from

==========
Add GetOriginalRequestURL() to NavigationItem interface.

This is part of the ongoing effort to move functionality from
CRWSessionEntry into NavigationItem.

BUG=674905, 454984
==========

to

==========
Add GetOriginalRequestURL() to NavigationItem interface.

This is part of the ongoing effort to move functionality from
CRWSessionEntry into NavigationItem.

BUG=674905, 454984

Review-Url: https://codereview.chromium.org/2578173005
Cr-Commit-Position: refs/heads/master@{#445607}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c3f6c83745f372982c6bb5d6d87...
==========

[commit-bot: I haz the power, 2017-01-24 02:24:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5c3f6c83745f372982c6bb5d6d87...