src/isolate.cc - Issue 2578173004: [promisehook] Fire init hook for promise subclass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2578173004: [promisehook] Fire init hook for promise subclass (Closed)

Patch Set: Fix test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 46805d26df30d63f2376925973ad25441c0f8c7b..647d71b66e819a4fed98d3c24e55670ff44d8ea9 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -3169,7 +3169,7 @@ void Isolate::FireCallCompletedCallback() {

void Isolate::SetPromiseHook(PromiseHook hook) { promise_hook_ = hook; }

-void Isolate::RunPromiseHook(PromiseHookType type, Handle<JSPromise> promise,

+void Isolate::RunPromiseHook(PromiseHookType type, Handle<JSObject> promise,

Handle<Object> parent) {

if (promise_hook_ == nullptr) return;

promise_hook_(type, v8::Utils::PromiseToLocal(promise),